[reidbaker-agent]

Update to skills_lint 0.5.3.

@reidbaker

Details

No issue tracks this routine dependency update, so this PR does not list one.

Updates the skills_lint dev dependency in tool/ from ^0.5.1 to ^0.5.3, and:

• Adds expect(config.parsingErrors, isEmpty) to tool/test/validate_skills_test.dart. parsingErrors lists errors in skills_lint.yaml itself. The 0.5.3 CHANGELOG notes that validateSkills prints each config.parsingErrors entry as a warning and still returns true, so without this check a typo in skills_lint.yaml (for example, an unknown rule name, which 0.5.3 reports as a config error) would still pass the test.
• Regenerates the root pubspec.lock with flutter pub get. This moves skills_lint from 0.5.1 to 0.5.3 and adds tar 2.0.3, a new transitive dependency of skills_lint 0.5.3.

Local checks against skills_lint 0.5.3 from pub.dev: flutter test test/ in tool/ passes (including validate_skills_test.dart), dart run skills_lint exits 0, dart format makes no changes, and dart analyze finds no issues.

I prepared this change with help from an AI agent and reviewed it.

Pre-launch Checklist

General checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read the Flutter Style Guide recently, and have followed its advice.
• I signed the CLA.
• I updated/added relevant documentation (doc comments with ///).

Issues checklist

• I listed at least one issue that this PR fixes in the description above.
• I listed at least one issue which has the contributions-welcome or good-first-issue label.
• I did not list at least one issue with the contributions-welcome or good-first-issue label. I understand this means my PR might take longer to be reviewed.

Tests checklist

• I added new tests to check the change I am making...
• OR there is a reason for not adding tests, which I explained in the PR description.

AI-tooling checklist

• I did not use any AI tooling in creating this PR.
• OR I did use AI tooling, and...
  • I read the AI contributions guidelines and agree to follow them.
  • I reviewed all AI-generated code before opening this PR.
  • I understand and am able to discuss the code in this PR.
  • I have verifed the accuracy of any AI-generated text included in the PR description.
  • I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments.

Feature-change checklist

• This PR does not change the DevTools UI or behavior and...
  • I added the release-notes-not-required label or left a comment requesting the label be added.
• OR this PR does change the DevTools UI or behavior and...
  • I added an entry to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.
  • I included before/after screenshots and/or a GIF demo of the new UI to my PR description.
  • I ran the DevTools app locally to manually verify my changes.

Requesting the release-notes-not-required label: this PR only changes repo tooling.

If you need help, consider asking for help on Discord.

[gemini-code-assist]

Code Review

This pull request updates the skills_lint package to version 0.5.3, enables the disallowed-field lint rule, and adds an assertion in validate_skills_test.dart to ensure configuration parsing succeeds. Feedback was provided to improve the readability of the test failure message by joining the parsing errors with newlines instead of printing the raw list.

[reidbaker]

lets not add disallowed-fields

[reidbaker-agent]

Removed in 0142363. tool/skills_lint.yaml is unchanged from master now; the PR only bumps skills_lint and adds the parsingErrors check.

[reidbaker-agent]

The Dart Code Metrics failure isn't caused by this PR, which changes only tool/ and pubspec.lock. It's already failing on master: dcm check-unused-code flags two unused members in packages/devtools_app/lib/src/screens/inspector/layout_explorer/ui/layout_explorer_widget.dart (lines 52 and 55). The last master run, 41127784658, failed on the same two lines.