Repository navigation
Preserve queued async generator ordering - #4568
Open
Aghayenoor wants to merge 1 commit into
Open
Aghayenoor wants to merge 1 commit into
Aghayenoor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When esbuild lowers an async generator, each queued request waits for a promise reaction before resuming the generator. This can run the previous request’s
.then()handler before the next part of the generator body, reversing the order seen with native async generators.Keep an explicit FIFO queue and start the next request as soon as the current one settles. A synchronous throw rejects its request and advances the queue.
Fixes #4566.
go test ./...andnode scripts/end-to-end-tests.jspassed. The ordering regression fails before the fix and passes in both native and lowered execution afterward. The test also covers a queuedthrow()followed bynext().