Repository navigation
Fix lifecycle acceptance for the two-argument deposit ABI - #27
Open
AkshatGada wants to merge 1 commit into
Open
AkshatGada wants to merge 1 commit into
AkshatGada wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifecycle acceptance runner currently stops at its first deposit: it passes three arguments to the vault's new two-argument
deposit(bytes32,uint128)method. This prevents the later usage, settlement, withdrawal and recovery scenarios from running.The CI run for the current main revision reproduces the failure:
Changes
Validation
Local validation used the exact seven-file patch in this PR. The full suites ran on October 16; the 20 focused tests were rerun before publication on October 17.
npm run test:e2e:v2go test -race ./...andgo vet ./...passedRust formatting and Clippy with warnings denied, golden calldata and all four withdrawal encoders on Anvil, real nginx/signer integration, docs type/lint/build, Docker build/release-flag checks, asset/version/build guards and packaging fixture checks also passed. The suites intentionally ignored one fixture-writer test and two tests requiring external ceremony files.
Tools: Node 24.22.0, Rust 1.99.0, Foundry 1.5.1, solc 0.8.28, crate-built wasm-bindgen 0.2.117 and Go 1.26.5 on macOS arm64.
The main reproduction command is:
After its dependency and contract-build prerequisites, the focused checks can also run directly:
Scope
This changes the acceptance harness, its regression and documentation. Protocol, contract, server and production SDK implementations are unchanged. The full lifecycle uses real proofs/contracts/daemons on disposable Anvil with mock provider/OA/price-feed services and a mini bundler. It does not establish live-network settlement, real bundler acceptance, or immediate SDK inference while an indexer is still catching up to a deposit.