Repository navigation
Conversation
…ument fork-chain selectors
0xiamflux
previously approved these changes
Nov 20, 2026
lumoswiz
previously approved these changes
Nov 20, 2026
maurelian
previously approved these changes
Nov 20, 2026
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three Cantina findings from the U22 review. Two are about OPCM (
15.1,15.3) and one is a docs gap (10). InOPContractsManagerV2._isPermittedInstruction, the note on upgrade allowances is rewritten: an allowance needed for only one upgrade must be tied to that upgrade with an explicit release check and removed once the upgrade is done, and an allowance kept for every upgrade must say why it is permanent. The unused_isMatchingInstructionhelper is removed fromOPContractsManagerUtilsCaller, and theUpgradeUtils.gasLimits()NatSpec now namescomputeRecommendedGasLimitand the test that enforces it.For
10,contract-dev.mdand theprepare-upgrade-envrecipe comment now documentFORK_BASE_CHAINandFORK_OP_CHAIN, with an example for running the upgrade tests against Sepolia. OPCM gets a patch bump to 10.0.2 because the comment change alters its source hash. Removing the helper doesn't change OPCM's bytecode.