Skip to content

contracts-bedrock: tighten OPCM allowance note, drop dead helper, doc… - #24319

Open
0xOneTony wants to merge 3 commits into
developfrom
tony/u22-docs-cleanup
Open

0xOneTony wants to merge 3 commits into
developfrom
tony/u22-docs-cleanup

Conversation

@0xOneTony

Copy link
Copy Markdown
Collaborator

Addresses three Cantina findings from the U22 review. Two are about OPCM (15.1, 15.3) and one is a docs gap (10). In OPContractsManagerV2._isPermittedInstruction, the note on upgrade allowances is rewritten: an allowance needed for only one upgrade must be tied to that upgrade with an explicit release check and removed once the upgrade is done, and an allowance kept for every upgrade must say why it is permanent. The unused _isMatchingInstruction helper is removed from OPContractsManagerUtilsCaller, and the UpgradeUtils.gasLimits() NatSpec now names computeRecommendedGasLimit and the test that enforces it.

For 10, contract-dev.md and the prepare-upgrade-env recipe comment now document FORK_BASE_CHAIN and FORK_OP_CHAIN, with an example for running the upgrade tests against Sepolia. OPCM gets a patch bump to 10.0.2 because the comment change alters its source hash. Removing the helper doesn't change OPCM's bytecode.

0xiamflux
0xiamflux previously approved these changes Nov 20, 2026
@0xOneTony
0xOneTony marked this pull request as ready for review November 20, 2026 17:55
@0xOneTony
0xOneTony requested review from a team and mds1 November 20, 2026 17:55
@0xOneTony
0xOneTony requested a review from a team as a code owner November 20, 2026 17:55
lumoswiz
lumoswiz previously approved these changes Nov 20, 2026
maurelian
maurelian previously approved these changes Nov 20, 2026
@0xOneTony
0xOneTony dismissed stale reviews from maurelian, lumoswiz, and 0xiamflux via 552940c November 21, 2026 01:03
@0xOneTony
0xOneTony requested a review from a team as a code owner November 21, 2026 02:11
@mintlify

mintlify Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Optimism-Docs 🟢 Ready View Preview Nov 21, 2026, 2:11 AM

This branch was successfully deployed

1 active deployment
staging - docs/public-docs — 587e30d4 Deployed Nov 21, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants