Repository navigation
Reuse upstream ACME account registrations - #73
Closed
florianmulatz wants to merge 2 commits into
Closed
florianmulatz wants to merge 2 commits into
florianmulatz wants to merge 2 commits into
Conversation
Persist the upstream account key and registration URL so issuance and revocation reuse one ACME account across requests and restarts. Add safe state handling, tests, and account_key_path configuration documentation.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document that certificate issuance and revocation reuse the persisted account. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Author
|
Closing as a duplicate of #70, which addresses the same upstream ACME account reuse problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account_key_path, defaulting to/opt/acme-proxy/db/account.key, while preserving existing configuration compatibility.Validation
go test ./externalcas(withCGO_ENABLED=0)go vet ./externalcasgofmton all changed Go filesCloses #60