Skip to content

Reuse upstream ACME account registrations - #72

Closed
florianmulatz wants to merge 2 commits into
esnet:mainfrom
florianmulatz:florian-mulatz-ghifx-reuse-upstream-acme-account
Closed

florianmulatz wants to merge 2 commits into
esnet:mainfrom
florianmulatz:florian-mulatz-ghifx-reuse-upstream-acme-account

Conversation

@florianmulatz

Copy link
Copy Markdown

Summary

  • Persist and reuse the upstream ACME account key and registration URL for certificate issuance and revocation across requests and restarts.
  • Add optional account_key_path, defaulting to /opt/acme-proxy/db/account.key, while preserving existing configuration compatibility.
  • Write account key and registration metadata atomically with owner-only permissions, and fail safely if persisted state is missing, corrupt, or mismatched.
  • Serialize first-time registration so concurrent requests do not create duplicate accounts.
  • Add account-reuse and persistence tests and document the new configuration.

Validation

  • go test ./externalcas (with CGO_ENABLED=0)
  • go vet ./externalcas
  • gofmt on all changed Go files

Closes #60

florianmulatz and others added 2 commits November 6, 2026 05:48
Persist the upstream account key and registration URL so issuance and revocation reuse one ACME account across requests and restarts. Add safe state handling, tests, and account_key_path configuration documentation.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document that certificate issuance and revocation reuse the persisted account.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@florianmulatz
florianmulatz deleted the florian-mulatz-ghifx-reuse-upstream-acme-account branch November 6, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persist the ACME account key: dns01_txt mode creates a new Let's Encrypt account per certificate

1 participant