Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains following minor code modifications
What's changed in this PR
1. Modfy
DotNetCliCommandExecutor.csReplace code to use
string.Splitinstead of creating non-cached compiled regex instance.(This code path is called only once. so there is no need to create regex instance)
2. Replace code that using double-lookup
Replace existing codes that using double-lookup to use
TryGet*pattern instead.3. Replace existing read-only dictionary to use
FrozenDictionarySystem.Collections.Immutablepackage is already transitively referenced by other packages.So
FrozenDictionarycan be used on all platforms.Note
These changes are suggested when using
analyzing-dotnet-performancedotnet-skill (https://github.com/dotnet/skills)And there are remaining suggestions exists not handled yet.
To code review costs lower. It might be better to run these skills and fix code on maintainer side.