Repository navigation
[agentbricks] Wait for dev's next steps in the dev template suites - #832
Merged
elainewang-db merged 1 commit intoOct 30, 2026
Merged
Conversation
Since databricks#812, `agentbricks dev` prints its next-steps panel (with the `agentbricks endpoint invoke` command) only once its own readiness poll sees the agent answering. `test_dev_templates` waits for the port itself and then read the log once, so it could read it before the panel was written and fail with no invoke command found. Poll the log for the invoke command for up to 30 seconds instead, and stop early if `dev` exits. Co-authored-by: Isaac <no-reply@databricks.com>
elainewang-db
enabled auto-merge (squash)
October 30, 2026 20:50
jamesbxwu
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test_dev_templatesnow polls theagentbricks devlog for the printedagentbricks endpoint invokecommand, for up to 30 seconds, instead of reading the log once. It stops early ifdevexits.Why
Since #812,
agentbricks devprints its next-steps panel only once its own readiness poll (every 0.25s) sees the agent answering on its port. The test waits for that port separately (wait_until_serving, which counts the 404 fromGET /as up) and then read the log immediately, so it could read it before the panel was written. That failedagentbricks_dev_functional (ubuntu-latest)on #831 (job):test_dev_templates[langgraph-custom],assert 0 == 1on the invoke command count, with the log ending at the probe'sGET /404 and "Starting agent locally…". The same job passed on #812 and onmainat that commit.This is test-only. The product behaves as intended: the panel appears once the agent answers.
Testing
uv run pytest tests/suites/test_dev.py -k test_dev_templates --workspace fake -n 5: 5 passed. The race is intermittent, so a local pass doesn't prove it's gone.ruff check/ruff format --checkclean.This pull request and its description were written by Isaac.