Repository navigation
perf(website): drop unused landing scroll handler - #1364
Merged
julioest merged 1 commit intoOct 30, 2026
Merged
Conversation
The handler wrote six custom properties to :root on every scroll event, forcing a full style recalc. Nothing reads them. Fixes cppalliance#1347
Contributor
|
| Scope | Lines Δ% | Lines Δ | Lines + | Lines - | Files Δ | Files + | Files ~ | Files ↔ | Files - |
|---|---|---|---|---|---|---|---|---|---|
| 📄 Docs | 100% | 104 | - | 104 | 4 | - | 4 | - | - |
| Total | 100% | 104 | - | 104 | 4 | - | 4 | - | - |
Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)
🔝 Top Files
- docs/website/index.html (Docs): 44 lines Δ (+0 / -44)
- docs/website/index.html.hbs (Docs): 44 lines Δ (+0 / -44)
- docs/ui/src/css/vars.css (Docs): 8 lines Δ (+0 / -8)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1364 +/- ##
========================================
Coverage 83.21% 83.21%
========================================
Files 35 35
Lines 3670 3670
Branches 845 845
========================================
Hits 3054 3054
Misses 410 410
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://1364.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-10-22 00:09:22 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the landing page's
scrollhandler. It wrote six custom properties (--x1..--y3) to:rooton every scroll event, but nothing reads them anymore. The background they used to move is gone, so each event made the browser recalculate styles for the whole page for nothing. Someone on r/cpp reported it as stutter while scrolling.scrolllistener and theDOMContentLoadedscript that set the same propertiesdocs/website/styles.cssanddocs/ui/src/css/vars.cssFixes #1347
Testing
Headless Chromium at 1440×900, scrolling down to
scrollY7200 in 120 wheel steps::rootstyle writesI haven't profiled it in a real browser on a machine that stutters. If it still stutters, check the
backdrop-filter: blur(10px)rules on fixed and sticky elements instyles.cssnext.I edited
docs/website/index.htmlby hand to match the template, as in #1354. The nextrender.jsrun should give the same output.