Repository navigation
fix(email): keep display names when sending over SMTP - #710
Merged
Merged
Conversation
m4tx
requested review from
ElijahAhianyo and
seqre
and
a balanced review from Copilot
October 16, 2026 07:09
|
Bencher Report| Project | cot |
| Branch | fix-mailing-display-names |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 15,653.00 µs(+31.67%)Baseline: 11,888.30 µs | 18,543.38 µs (84.41%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,058.60 µs(+4.68%)Baseline: 1,011.32 µs | 1,348.28 µs (78.51%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1,027.60 µs(+7.65%)Baseline: 954.55 µs | 1,256.64 µs (81.77%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 957.78 µs(+4.64%)Baseline: 915.33 µs | 1,213.44 µs (78.93%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 15,960.00 µs(-5.08%)Baseline: 16,814.84 µs | 22,148.74 µs (72.06%) |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change consistently handles all address fields, with regression coverage and no identified blocking issues.
0 open findings
What changed in this PR
Fixes SMTP message conversion to preserve email display names across all address fields.
Changes:
- Centralizes address conversion in a shared helper.
- Adds regression coverage for sender and recipient display names.
| File | Description |
|---|---|
| cot/src/email/transport/smtp.rs | Preserves display names during conversion and adds regression tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
ElijahAhianyo
approved these changes
Oct 19, 2026
m4tx
force-pushed
the
fix-mailing-display-names
branch
from
October 19, 2026 16:40
b41a201 to
03b5f74
Compare
m4tx
enabled auto-merge (squash)
October 19, 2026 16:40
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change