Repository navigation
docs: note that the ServiceMonitor needs the metrics Service - #288
Merged
hagaibarel merged 1 commit intoNov 4, 2026
Merged
hagaibarel merged 1 commit into
hagaibarel merged 1 commit into
Conversation
With its default selector the ServiceMonitor matches the Service rendered by prometheus.service.enabled, so enabling only prometheus.monitor.enabled produces a ServiceMonitor that selects nothing. Say so in the README and values.yaml, and describe what the default monitor selector matches. Chart 1.50.1. Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
hagaibarel
approved these changes
Nov 4, 2026
Collaborator
|
Thanks for the PR! |
Open
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
With the default
prometheus.monitor.selector, the ServiceMonitor selects the-metricsService, which is only rendered whenprometheus.service.enabledis true. Enabling justprometheus.monitor.enabledgives a ServiceMonitor that matches nothing, and nothing in the docs says the two are linked.This documents the dependency in the README parameter table and in
values.yaml, and says what the default monitor selector matches. No template change: a customprometheus.monitor.selectorcan legitimately point at another Service, so rendering or failing based onprometheus.service.enabledwould get in the way there. Happy to switch to auto-rendering the metrics Service instead if you prefer that.Bumped the chart to 1.50.1.
helm lintandhelm unittest --strict charts/corednspass.Which issues (if any) are related?
Fixes #274
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.