Skip to content

Configure Renovate to group stylelint dependencies - #2365

Open
erikgb wants to merge 2 commits into
masterfrom
stylelint-group
Open

Configure Renovate to group stylelint dependencies#2365
erikgb wants to merge 2 commits into
masterfrom
stylelint-group

Conversation

@erikgb

@erikgb erikgb commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Some major version upgrades of stylelint packages from Renovate are currently failing, and I think it's because the dependencies need to be upgraded together.

@erikgb
Configure Renovate to group stylelint dependencies
1bfe8c8 
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 8, 2026
@erikgb
erikgb requested a balanced review from Copilot November 8, 2026 14:35
@cert-manager-prow

cert-manager-prow Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hjoshi123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2026
@erikgb

erikgb commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

/cc @hjoshi123

@cert-manager-prow
cert-manager-prow Bot requested a review from hjoshi123 November 8, 2026 14:35
@netlify

netlify Bot commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cert-manager ready!

Name Link
🔨 Latest commit bcc2d0e
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/6af089dae968e3c8aa705624
😎 Deploy Preview https://deploy-preview-2365--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI reviewed Nov 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Extending group:stylelint inside a package rule creates invalid nested rules without an outer match selector, causing Renovate to reject the configuration and block dependency updates.

1 open issue
What changed in this PR

This PR aims to group Stylelint dependency updates in Renovate so related packages can upgrade together, addressing suspected causes of failing major-version updates.

Changes:

  • Adds a Stylelint grouping preset reference.
  • Compacts the existing npm manager selector without changing its behavior.
File Description
.github/​renovate.json5 Adds Stylelint grouping configuration alongside the existing miscellaneous npm update rule.

Review effort: Balanced

Comment thread .github/renovate.json5 Resolved
@erikgb
Potential fix for pull request finding 'Inline the Stylelint preset r…
bcc2d0e 
…ule to avoid invalid nested packageRules'

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2026
@erikgb

erikgb commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

/label tide/merge-method-squash

@cert-manager-prow cert-manager-prow Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 8, 2026
@erikgb
erikgb requested a balanced review from Copilot November 8, 2026 14:40
Copilot AI reviewed Nov 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Renovate configuration update to group Stylelint dependencies.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@hjoshi123 hjoshi123 Awaiting requested review from hjoshi123

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erikgb