Repository navigation
Import transit stations and add station ranking and area suppression - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cypress currently filters out ordinary transit stations and does not classify plain railway stations or bus stops as venues. Import station-level destinations and add shared transit ranking across search and autocomplete.
prefer_train_stations=trueto strengthen it. Apply it before candidate and final result truncation.suppress_cities_near_stations=true: a returned, higher-ranked rail station may suppress a similarly named locality within 3 km; metro/tram stations may suppress a neighbourhood within 1 km. Require compatible administrative context and equal-or-better lexical relevance, preserve qualifiers such as North/Airport, and refill from a bounded candidate pool. Missing or filtered stations cannot erase an area.Validation:
cargo check --locked --all-targets,cargo test --locked --all-targets(95 passed, one pre-existing ignored),cargo fmt --all -- --check, shell syntax checks, andgit diff --check. Tests include real mmap top-1 ranking and alternating flags with a warmed query cache, import/category round trips, platform exclusion, v1/v2 compatibility, parameter parsing, suppression guards and refill. No production dataset import or latency benchmark was run.Rollout: regenerate filtered PBFs, reimport with
--refresh, and recompile. Deploy the new query binary before publishing dense v2; rolling back the binary also requires the older compiled generation. This imports explicit OSM destinations and station multipolygons; it does not synthesize stations from platform-only stop areas or import GTFS. Details and commands are in docs/transit-search.md.