Repository navigation
Conversation
…ith used Poetry version The Snyk fix pinned poetry>=2.3.4 in ci/requirements.txt and bumped poetry to 2.3.4 in requirements.txt, but poetry-plugin-tweak-dependencies-version 1.5.7 requires poetry<2.1.0, and pip failed with ResolutionImpossible. The poetry upgrade is blocked by the plugin incompatibility, and while poetry stays at 1.8.5, the following transitive dependencies cannot be upgraded to their fixed versions: - dulwich: poetry requires dulwich<0.23.0, the fixes need dulwich>=1.1.0 (SNYK-PYTHON-DULWICH-17054926/17054927/17266106/18016337/20416729/20416732/22220108) - virtualenv: poetry requires virtualenv<21.0.0, the fixes need virtualenv>=21.7.11 (SNYK-PYTHON-VIRTUALENV-20335491/20335492/20335493/20335500/21282339/21282342/21282424/21282484/21282509) - filelock: virtualenv requires filelock<4.0.0, the fixes need filelock>=4.0.9 (SNYK-PYTHON-FILELOCK-21280750/21280753/21280754/21280755/21280756/21280759/21280760/21280761/21689161/21689162/21802489/21802490/21802520) - poetry itself: Plugin not compatible with new Poetry version (SNYK-PYTHON-POETRY-15873752/16122096) Drop the Snyk pins from ci/requirements.txt and requirements.txt and ignore those advisories in .snyk and ci/.snyk, following the same policy already applied on the 1.21 branch. Failing CI: https://github.com/camptocamp/tilecloud-chain/actions/runs/42282692329/job/128115474462 Audit logs: https://geoservices-int.camptocamp.com/github/logs/3302538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Snyk policy files
.snykandci/.snykon the 1.22 stabilization branch to ignore the poetry/dulwich/filelock/virtualenv advisories that cannot be fixed on this branch, and stop the GHCI audit from re-applying the unresolvable Poetry >= 2.3.4 pins.Context
ci/requirements.txtraises pipResolutionImpossiblebecause the Snyk pinpoetry>=2.3.4conflicts withpoetry-plugin-tweak-dependencies-version==1.5.7(requirespoetry<2.1.0), which is still needed by[build-system]on this branch.ghci/audit/snyk/1.22branch is force-pushed by GHCI on every audit run, so fixes pushed there are overwritten; landing the ignores on1.22makes the audit skip these advisories.Implementation Details
.snykandci/.snykignore 31 advisories: 2 on poetry (fix needs poetry>=2.3.x, blocked by the tweak plugin), 7 on dulwich (poetry requires dulwich<0.23.0), 13 on filelock (virtualenv requires filelock<4.0.0), 9 on virtualenv (poetry requires virtualenv<21.0.0).Impact/Risks
requirements.txt/ci/requirements.txtinstalled in the Docker build stage), not the application runtime dependencies exported frompoetry.lock.