Repository navigation
Conversation
Shared gauges mixed data between parallel requests and between databases. This also avoids cleaning up stale series.
…s.metric The abstract model held no state, it was only an extension point.
The cron and the prometheus.metric table only existed to pass values from the cron process to the HTTP workers. Querying the database directly when /metrics is scraped removes the cron, the table and the staleness.
divad1196
requested review from
florentx and
gurneyalex
and removed request for
gurneyalex
October 1, 2026 09:59
divad1196
changed the title
divad1196
force-pushed
the
14.0-monitoring_prometheus_queuejob_divad1196
branch
from
October 1, 2026 11:40
9bda634 to
6476454
Compare
1 task
florentx
approved these changes
Oct 7, 2026
florentx
left a comment
florentx
left a comment
Contributor
There was a problem hiding this comment.
IMO these changes make sense.
I don't have experience with Prometheus, though.
Author
|
@gurneyalex @yankinmax @vvrossem Opinion? |
For context on #535: it only took the per-request I don't know Prometheus well enough to have a strong opinion on cron vs on-the-fly. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
2 different proposals in 1 PR:
In [ADD] monitoring_prometheus_queue_job #529 it was mentioned that `15 pods would repond" but that's an infrastructure matter: only one pod should be queried at the time.
prometheus.metricstable, we can drop the last commit.The new code
prometheus.metricsGauge/Registrycode. This avoid concurrency issues.@gurneyalex