Skip to content

Changelog: Never create a release when create-release is disabled - #1547

Merged
sbrunner merged 1 commit into
masterfrom
changelog-never-create-release
Nov 8, 2026
Merged

sbrunner merged 1 commit into
masterfrom
changelog-never-create-release

Conversation

@sbrunner

@sbrunner sbrunner commented Nov 8, 2026

Copy link
Copy Markdown
Member

Summary

With create-release: false, the changelog module never creates a release.

Context

Only the tag creation event was guarded by the create-release option. The changelog generation flow (triggered by the release, pull_request, milestone and discussion events) called _create_release unconditionally when no release existed for the tag, or when the release was deleted between the get and the update. For example, editing a milestoned closed pull request of a tag without a release created one even with create-release: false.

Implementation Details

  • Changelog.process reads create-release (default configuration.CREATE_RELEASE_DEFAULT) in the changelog generation path and skips the release creation, with a log, when the option is disabled.
  • The existing releases still get their changelog body updated, whatever the option value.

Impact/Risks

  • No configuration change, no migration. Only the repositories with create-release: false are affected: they stop getting unexpected releases.

@sbrunner sbrunner added the bug Something isn't working label Nov 8, 2026
@sbrunner
sbrunner merged commit 9291a9e into master Nov 8, 2026
15 checks passed
@sbrunner
sbrunner deleted the changelog-never-create-release branch November 8, 2026 11:49

This branch was previously deployed

1 inactive deployment
publish — 1d5f3bad Deployed Nov 8, 2026 by sbrunner via Publish #7358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant