Repository navigation
Conversation
ST0010 commands used a ROM-controlled sort count for two 32-entry tables and normalized -32768 coordinates in int16 values. Crafted inputs could therefore access memory outside the ST0010 object. Reject sort counts above the table capacity and normalize coordinates in 32-bit temporaries before indexing the arctangent table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ST0010::op_02()used a count supplied through emulated RAM to operate on two 32-entry tables without checking their capacity. Separately,op_01()normalized coordinates in 16-bit values, so negating -32768 could leave a negative index for the arctangent table. A crafted ST010 ROM could trigger native out-of-bounds accesses, potentially crashing or corrupting the emulator process.Reject sort counts above the table capacity. Normalize coordinates and the quadrant in 32-bit temporaries before indexing the arctangent table, ensuring both indexes remain between 0 and 31.