Repository navigation
fix(engine): avoid oversized allocation in String.prototype.repeat - #5615
Open
Basharkhan7776 wants to merge 1 commit into
Open
Basharkhan7776 wants to merge 1 commit into
Basharkhan7776 wants to merge 1 commit into
Conversation
github-actions
Bot
added
C-Tests
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5367.
It changes the following:
Vec<JsStr>construction inString.prototype.repeat(which allocatednstring views) with a newJsString::repeathelper that allocates a single result buffer ofn * lenunits and fills it by doubling copies.RangeErrorinstead of aborting the process.JsString::repeatand regression tests for loop-limit handling and moderate repeat counts.Validation:
cargo test -p boa_string --lib: 26 passed.cargo test -p boa_engine --lib builtins::string::tests::repeat: 9 passed.cargo fmt --all -- --check: passed.cargo clippy -p boa_string -p boa_engine --all-targets: passed."o".repeat(1<<30)now completes in ~1 second with ~1.1 GB RSS in a debug build (exit 0), instead of attempting a ~24 GiB allocation and aborting.