Repository navigation
Conversation
…erver The registry's completeness test checks its shape; this walks each entry against a real table and asserts the refusal and the wrong-target usage error both leave the table untouched.
This was referenced Nov 2, 2026
The block-writes entry is refused only where the route cannot stream; CI's shared server runs with wal_level=logical, so the copy ran live there instead of being refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One integration test walks the irreversible-operations registry against a real server and proves each entry is refused without its acknowledgement, rejected when the acknowledgement names another table, and leaves the table untouched either way.
Why
#282 added the registry and a unit test that it is complete, but that test checks the registry's shape, not the gates. Each gate has its own integration tests, written separately and asserting different things. Nothing ties a registry entry to evidence that its gate holds, so an entry could claim
--forcegates an operation while the gate itself is broken.What
TestIrreversibleOperationsAreGated(pkg/migrate/irreversible_registry_integration_test.go) gives every registry entry a real statement against a freshorderstable, with every other gate open so only the entry's own acknowledgement decides the outcome.Runreturns a usage error and a zero verdict.Test only; no behaviour change.
Before / after
Suppose a change breaks the force acknowledgement check so it accepts any table name, and an operator runs
ALTER TABLE app.orders ADD COLUMN nickname text UNIQUEwith--force app.customers.Stacked on #282; retarget to
mainonce it merges.