Repository navigation
Time out CLI browser login after ten minutes - #26
Merged
Merged
Conversation
jsibbison-square
force-pushed
the
jsib-261019-login-timeout
branch
from
October 18, 2026 22:27
a405b32 to
dd55a13
Compare
jsibbison-square
force-pushed
the
jsib-261019-login-timeout
branch
from
October 18, 2026 22:28
dd55a13 to
95e9fef
Compare
jsibbison-square
marked this pull request as ready for review
October 18, 2026 22:30
shu-hui-cash
approved these changes
Oct 18, 2026
shu-hui-cash
left a comment
shu-hui-cash
left a comment
There was a problem hiding this comment.
Nice find and thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a browser callback is missing or rejected because its state does not match,
bl auth logincurrently waits indefinitely. Bound the callback wait to ten minutes and reportBuilderLab CLI auth login timed out; rerun bl auth loginso the user can start a fresh attempt. Preserve callback results and the separate stopped-server error.Addresses the follow-up review on #22. Blox proxy authentication is unchanged.
Validation:
just check(formatting, Clippy, and all tests), including deterministic tests for timeout guidance, successful and failed callbacks, and a disconnected callback server.