Repository navigation
Conversation
yulangz
requested review from
CormickKneey,
HwVanICI,
Le8r0nJames,
PrometheusComing,
garrett4wade,
geshi001 and
sitabulaixizawaluduo
as code owners
November 6, 2026 08:44
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapt CPU-staged Muon for the separate WeftMoE engine integration without copying that integration into this branch.
get_full_parameter_master(param)for complete locally owned CPU FP32 matrices. Residency callers drain the optimizer first; unowned/partial parameters returnNone.The Muon update algorithm and native kernels are unchanged.
Related Issue
Targets
feature/muon-optimizer-offloadfrom #1743. Complements #1891 and replaces the Muon-specific portion of #1890. This PR adds no AWEX/SGLang adapter implementation, example screenshots, dependencies, or lockfile changes. Both integration PRs are needed for end-to-end Muon + WeftMoE.Type of Change
Validation
test_gpu_staged_muon.py,test_gpu_staged_muon_checkpoint.py, andtest_megatron_optimizer_config.pyusing the Muon-capable Megatron-Core 0.19.0 environment.pre-commit run --all-filespassed; lockfiles match the Muon target branch.The combined-tree checkpoint check covers inner optimizer master/momentum state and BF16 materialization, not full Megatron distributed-checkpoint save/resume. No new full-model or multi-node RL run was launched.
Checklist