Repository navigation
tlog cdc test AbsoluteDeadline more robust under load - #14301
Merged
Merged
Conversation
Sometimes unit test /NativeCDC/TLogCommittedFrontier/AbsoluteDeadline
failed in nightlys (mostly for release-8.0 branch):
Assertion result.minKnownCommittedVersion == 93 failed
This was probably due to system load, where the peek timed-out
at 0.4 seconds, before the last intended fixture.advance(frontier)
which should be around 0.3 seconds (but can be more delayed under load).
Fix by stopping the frontier advance loop if the peek already timed-out,
and comparing to what (and when) the last frontier advance actually was.
tclinkenbeard-oai
approved these changes
Oct 16, 2026
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
How I tested this locally: First change the With and with this branch it always passes |
This comment has been minimized.
This comment has been minimized.
spraza
approved these changes
Oct 16, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes unit test /NativeCDC/TLogCommittedFrontier/AbsoluteDeadline failed in nightlys (mostly for release-8.0 branch):
This was probably due to system load, where the peek timed-out at 0.4 seconds, before the last intended fixture.advance(frontier) which should be around 0.3 seconds (but can be more delayed under load).
Fix by stopping the frontier advance loop if the peek already timed-out, and comparing to what (and when) the last frontier advance actually was.