Repository navigation
[release-8.0] Preserve the first uncopied backup log version on timeout - #14296
Open
tclinkenbeard-oai wants to merge 2 commits into
Open
tclinkenbeard-oai wants to merge 2 commits into
tclinkenbeard-oai wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saintstack
approved these changes
Oct 16, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #14119 to
release-8.0.When backup log copying times out, finish copying the current version and resume at the first omitted version. Stop both nested result loops at that boundary so later groups cannot overwrite the continuation version and skip mutations. Includes the three upstream regression tests.
Patch-release compatibility: protocol versions, RPC serialization, backup log key/value formats, task version 1, and the existing
nextBeginVersionparameter encoding are unchanged. Older and newer agents can read the same persisted tasks. This is an unmodified cherry-pick of the upstream patch.Validation: source compatibility audit, formatting, and
git diff --checkpass. Bothfdbclient_testandfdbserverbuild successfully. All 3/backup/copy-log-continuationtests pass in native and Sim2 modes.tests/fast/BackupToDBCorrectness.tomlpasses with its consistency check (seed 14119, buggify on).