Repository navigation
PostgreSQL, Snowflake: Keep the signature in GRANT and REVOKE ON FUNCTION - #2727
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
==========================================
+ Coverage 82.30% 82.32% +0.02%
==========================================
Files 42 42
Lines 35294 35263 -31
Branches 35294 35263 -31
==========================================
- Hits 29047 29030 -17
+ Misses 2690 2685 -5
+ Partials 3557 3548 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/grant-function-signature
branch
3 times, most recently
from
October 26, 2026 21:03
e631f27 to
df4db60
Compare
LucaCappelletti94
force-pushed
the
upstream/grant-function-signature
branch
from
October 26, 2026 21:39
df4db60 to
4733038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRANTandREVOKE ... ON FUNCTIONandON PROCEDUREkept the argument list asarg_types: Vec<DataType>, so an empty list and an absent one gave the same AST andGRANT EXECUTE ON FUNCTION f() TO bobprinted back asGRANT EXECUTE ON FUNCTION f TO bob, which mean quite different things, asf()names the zero-argument overload, and a barefis accepted only when no other function shares the name. Argument names and modes failed to parse, which breakspg_dumpoutput such asREVOKE ALL ON FUNCTION public.f(p_id uuid) FROM PUBLIC, and only one function was accepted per statement.GrantObjects::FunctionsandGrantObjects::Proceduresnow holdVec<FunctionDesc>, the typeDROP FUNCTIONandDROP PROCEDUREalready use, and the parser reads them with the sameparse_function_desc. They replace theFunctionandProcedurevariants added for Snowflake in #1930, so this changes the public AST. Snowflake statements such asGRANT USAGE ON FUNCTION db1.sc1.foo(INT) TO ROLE role1parse and print unchanged.