[mcollina]

Speed up stringify() for keys and values that contain no characters requiring escaping. encodeString now first scans for the first escapable character with a native regex when the string is long enough, and returns it unchanged when it is already safe, instead of running the per-character scanning loop. Short strings keep the original tight loop because regex call overhead dominates there.

Measured against the previous implementation, this is neutral on the existing short-string benchmark and ~9% faster on realistic long-value workloads; a 40+ character safe string encodes roughly 2x faster. All tests pass and 20k fuzz cases match node:querystring.

---

Note

Low Risk
Localized performance change to URL encoding with intended identical output; no security or API surface changes.

Overview
Speeds up query-string encoding when keys or values are long and already “safe” (no characters that need percent-encoding).

encodeString now uses a native regex pre-scan for inputs ≥ 16 characters to detect the first character that must be escaped. If none are found, it returns the input unchanged instead of walking every code unit. When escaping is needed, it only runs the existing per-character loop from that point, prefixing the safe leading slice. Shorter strings still use the original tight loop only, because regex overhead would outweigh the benefit.

^{Reviewed by Cursor Bugbot for commit 6bb6c67. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.23%. Comparing base (9fe75ff) to head (6bb6c67).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   69.31%   70.23%   +0.91%     
==========================================
  Files           7        7              
  Lines         453      467      +14     
  Branches       74       78       +4     
==========================================
+ Hits          314      328      +14     
  Misses        136      136              
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Reviewed by Cursor Bugbot for commit 6bb6c67. Configure here.}

[cursor]

Regex omits underscore from safe set

Medium Severity

The needEscape regex omits _, which noEscape treats as safe. Long strings containing underscores therefore miss the unchanged-return path and allocate a prefix plus a concatenation even when every character is already safe.

 

^{Reviewed by Cursor Bugbot for commit 6bb6c67. Configure here.}