Repository navigation
Add Iranian public holiday and Zoroastrian calendar references - #28
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b55f2528b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| festivals = [ | ||
| (0, "Nowruz"), | ||
| (5, "Khordad Sal / Birth of Zoroaster"), | ||
| (102, "Tirgan"), |
There was a problem hiding this comment.
When yearly inference evaluates these new Zoroastrian calendars, Tirgan at offset 102 always coincides with day 3 of the Maidyoshahem Gahambar window, yet _merge_holidays preserves both because their names differ. infer_yearly then includes the same day's percentile twice in holiday_percentiles while calculating enrichment from a deduplicated holiday_days set, so that date gets disproportionate weight and holiday_dates_seen is overstated. The combined IR calendar has similar Solar/Shia collisions; score unique dates while retaining all names as evidence.
Useful? React with 👍 / 👎.
Yearly activity inference currently has no Iranian calendar candidates. This adds a combined Iran public-holiday reference, separate Solar Hijri and Shia references, and Bastani, Fasli, Qadimi, and Shahanshahi Zoroastrian references to both holiday profiles.
Solar Hijri dates follow the Jalali model, while the traditional Zoroastrian calendars retain their 365-day drift. Lunar dates are explicitly marked as estimates, and the documentation distinguishes religious observances from nationwide closures. One-off government closures and historical regimes are outside these recurring reference sets.
Validation: