Repository navigation
fix(ComboBox): don't commit value on blur when isReadOnly - #10869
Open
mangeshraut712 wants to merge 4 commits into
Open
mangeshraut712 wants to merge 4 commits into
mangeshraut712 wants to merge 4 commits into
Conversation
Contributor
Author
|
CI is green on this one. Ready for review/merge when you have a chance — thanks. |
Contributor
|
LGTM. Thanks! |
snowystinger
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A read-only ComboBox still ran
commitValue()on blur. When bothvalueandinputValueare controlled and the selected item is not in the collection (e.g. async items not loaded yet), that path fires change events and apps that derive input text from the selection can clear a field the user never changed.Skip the blur commit when
isReadOnlyis set.Closes #10846
Test plan
isReadOnlywith a value missing from the collection does not fireonChange/onSelectionChangeon blur