Repository navigation
Conversation
- Typed the `Availability` the server gives each release provider - Showed "Not Configured", "Suspended" or "Manual Only" next to an auto-linking provider, with the server's reason as a tooltip - Left "Manual Only" out of the manual linking list, where such a provider works
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A release provider can be ticked for auto-linking and still never be used: it may not be configured (AniDB without credentials), held back by a suspension (an AniDB ban), or, with the new
ManualOnlykind on the server, only answer searches a person starts. The first provider to useManualOnlyis the Offline Importer, which cannot match files on its own until an admin adds an auto-match rule to its configuration. Ticking it under the auto-linking providers then does nothing, and nothing in the web UI says why.GET /api/v3/ReleaseInfo/Provideralready reports each provider'sAvailability, but the web UI showed none of it for release providers. The metadata source settings already show the same kind of status ("Not Configured", "Suspended"), so this follows that pattern.What
Availabilityobject (Kind,Reason,ResumesAt,SuspendedBy) and added it toReleaseProviderInfoType.ReleaseProviderAvailabilitylabel shown after the plugin name of each provider:Reasonis the tooltip, plus "Resumes ..." when a suspension has an end time (same format as the metadata source settings).Availableshows nothing. Whether a provider is ticked is the checkbox's job; the server reports availability apart from it, so an unticked provider still shows why it can't be used.release-info/providersquery, so the labels refresh after a save.Where
src/core/types/api/provider-availability.ts(new): the availability types. Kept generic, since relocation providers carry the same object.src/core/react-query/release-info/types.ts:AvailabilityonReleaseProviderInfoType.src/components/Settings/ReleaseProviderAvailability.tsx(new): the label.src/components/Settings/HashingAndReleaseSettings/ReleaseSettings.tsx: one line per list rendering the label.Testing
pnpm lint,pnpm tscheck,pnpm buildandpnpm testpass.ManualOnlyyet), signed in as a throwaway admin, which was deleted afterwards. No settings were saved.Availablefrom that core): no labels, layout unchanged, no console errors.Suspended, Offline ImporterManualOnlyand another providerNotConfigured: the labels and tooltips render as below, and "Manual Only" is left out of the manual linking list.Screenshots
Both lists with mocked availabilities:
The tooltip with the server's reason:
Feedback wanted
Relation to
feat/split-hashing-release-settingsThat unmerged branch moves the provider lists from
components/Settings/HashingAndReleaseSettings/ReleaseSettings.tsxintopages/settings/tabs/ReleaseSettings.tsxand removes theHashingAndReleaseSettingsfolder. To keep the merge easy, the label lives in its own component directly undercomponents/Settings/, and the change to the list is one import plus one line per list. Whichever branch merges second only needs to carry those lines over to the new file.