Repository navigation
fix(2.5.x): Sentry triage (unknown folders, list flattening, ignored errors) - #1530
Merged
Merged
Conversation
…onger exists Files can keep an ImportFolder ID after the folder is removed (missing files not yet cleaned up), so the lookup returns undefined. Show <Unknown> and the raw ID instead of throwing. Fixes SHOKO-WEBUI-25B
react-router doesn't await navigate() inside setSearchParams, so a replaceState rejection can't be caught by the caller. Only the URL query update is lost; search state lives in React. Refs SHOKO-WEBUI-25A
A page without a List made flatMap emit a single undefined, which then crashed callers such as the group tab (group.IDs of undefined). Refs SHOKO-WEBUI-19B
SignalR's FetchHttpClient aborts its own request on timeout, which surfaces as an unhandled AbortError we can't catch. Start failures are already handled and toasted in the signalr middleware. Refs SHOKO-WEBUI-23V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport-style counterpart of the master PR for the 2.5.x line (the code differs, so these are separate fixes rather than cherry-picks). Fixes crashes and noisy errors found while triaging recent Sentry issues on 2.5.x.
Fixes SHOKO-WEBUI-25B.
Relates toSHOKO-WEBUI-25A, 19B and 23V.Changes
Fixed
QuickSelectModal.tsx: don't crash when a file group's import folder no longer exists (e.g. the folder was removed but "remove missing files" wasn't run). Shows<Unknown> (ID: N)and the full location instead (25B).useFlattenListResult.ts: a page without aListmadeflatMapemit a singleundefined, which crashed callers such as the group tab. Missing pages and entries are now dropped (19B).Changed
main.tsx: ignore two errors in Sentry that come from outside our code and are already handled in the UI:The operation is insecure.fromhistory.replaceState, raised inside react-router'ssetSearchParamsas an unhandled rejection (25A).signal is aborted without reason(23V).