Skip to content

fix(2.5.x): Sentry triage (unknown folders, list flattening, ignored errors) - #1530

Merged
hidden4003 merged 4 commits into
v2.5.xfrom
fix/v2.5.x-sentry-triage-2026-11
Nov 3, 2026
Merged

hidden4003 merged 4 commits into
v2.5.xfrom
fix/v2.5.x-sentry-triage-2026-11

Conversation

@hidden4003

Copy link
Copy Markdown
Member

Summary

Backport-style counterpart of the master PR for the 2.5.x line (the code differs, so these are separate fixes rather than cherry-picks). Fixes crashes and noisy errors found while triaging recent Sentry issues on 2.5.x.

Fixes SHOKO-WEBUI-25B. Relates to SHOKO-WEBUI-25A, 19B and 23V.

Changes

Fixed

  • QuickSelectModal.tsx: don't crash when a file group's import folder no longer exists (e.g. the folder was removed but "remove missing files" wasn't run). Shows <Unknown> (ID: N) and the full location instead (25B).
  • useFlattenListResult.ts: a page without a List made flatMap emit a single undefined, which crashed callers such as the group tab. Missing pages and entries are now dropped (19B).

Changed

  • main.tsx: ignore two errors in Sentry that come from outside our code and are already handled in the UI:
    • Firefox's The operation is insecure. from history.replaceState, raised inside react-router's setSearchParams as an unhandled rejection (25A).
    • SignalR's own negotiate-timeout signal is aborted without reason (23V).

…onger exists

Files can keep an ImportFolder ID after the folder is removed (missing
files not yet cleaned up), so the lookup returns undefined. Show
<Unknown> and the raw ID instead of throwing.

Fixes SHOKO-WEBUI-25B
react-router doesn't await navigate() inside setSearchParams, so a
replaceState rejection can't be caught by the caller. Only the URL
query update is lost; search state lives in React.

Refs SHOKO-WEBUI-25A
A page without a List made flatMap emit a single undefined, which then
crashed callers such as the group tab (group.IDs of undefined).

Refs SHOKO-WEBUI-19B
SignalR's FetchHttpClient aborts its own request on timeout, which
surfaces as an unhandled AbortError we can't catch. Start failures are
already handled and toasted in the signalr middleware.

Refs SHOKO-WEBUI-23V
@hidden4003
hidden4003 merged commit eb340fc into v2.5.x Nov 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant