This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
feat(icons): Redraw login and sign-out to match Figma - #2278
Closed
josephjpearce wants to merge 1 commit into
Closed
josephjpearce wants to merge 1 commit into
josephjpearce wants to merge 1 commit into
Conversation
`login` now has its bracket on the right, with the arrow entering it, and both glyphs use the rounded frame from the Iconography file. `sign-out` is an alias of `exit`, so `exit` changes with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 615d676 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Closing in favor of RocketChat/Rocket.Chat#42659. RocketChat/Rocket.Chat#42607 moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Redraws the
loginandsign-outicons to match the updated Iconography designs (login, sign-out).login: the bracket is now on the right, with the arrow entering it. The old glyph had the bracket on the left, which read as "leave" more than "enter".sign-out: uses the same rounded frame as the newlogin, so the two read as a pair.Issue(s)
Raised during design review of RocketChat/Rocket.Chat#42470 (discussion navigation improvements). That PR uses these glyphs for the discussion Join / Leave buttons and the composer Join button. It refers to the icons by name and doesn’t depend on this change.
Further comments
sign-outis an alias ofexit(exit.dir.svg), soexitchanges too.@rocket.chat/iconsis bumped there.Data Display/Icon Defaultvisual regression baseline is updated for the two glyphs.@rocket.chat/iconsminor.🤖 Generated with Claude Code