Skip to content

fix: blank block over rooms after expanding a category on Android - #7847

Merged
diegolmello merged 1 commit into
developfrom
fix/android-category-expand-blank-block
Oct 27, 2026
Merged

diegolmello merged 1 commit into
developfrom
fix/android-category-expand-blank-block

Conversation

@Rohit3523

@Rohit3523 Rohit3523 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Proposed changes

On Android, after collapsing and expanding a category in the rooms list, a blank block covered the rooms below the screen and stayed there after scrolling. The block is the cover in SectionRevealFooter that slides away to reveal the expanded rooms. It hides itself only at the end of its entering animation, and on Android Reanimated puts the view's style opacity (1) back once that animation ends. Setting opacity: 0 in the cover's style keeps it hidden afterwards, and the reveal animation looks the same. The cover came in with #7707 (Liquid Glass).

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1806

How to test or reproduce

  1. On Android, log in with an account whose Channels category holds more rooms than fit below its header (about 16 on a Pixel 9)
  2. Tap the sort icon in the rooms list header, open Display and turn on Categories
  3. Collapse the Channels category, then expand it again
  4. Scroll down
  5. Observe all the rooms listed, with no blank block

Screenshots

Before After
Android
android-before.mp4
android-after.mp4
iOS 26
ios-before.mp4
ios-after.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

  • On iOS 26, the area under the last room (behind the Search bar) now shows the grey list background from launch. Before, it was light until the first collapse or expand.
  • Why the style and not the animation: on Android, Reanimated restores the view's style opacity after the entering animation, so the style is the value that has to be 0. Removing the opacity step from coverEntering or patching Reanimated would both be bigger changes for the same result.
  • No pointerEvents: 'none' on the cover: after collapse, expand and scroll on Android, tapping a room that sat under the old blank block opens it, and swiping it shows its row actions.
  • No unit test: the bug comes from Reanimated's native Android code, which Jest doesn't run.
  • Tested on the Pixel_9 emulator and iPhone 17 (iOS 26.5).

Summary by CodeRabbit

  • Style
    • The cover-styled room footer is now transparent, while its positioning remains unchanged. This changes how the footer appears when that style is applied.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5d49d3ad-384f-4c68-8334-e75d040c503d
Commits

Reviewing files that changed from the base of the PR and between 072e422 and 5b7dab2.

Files selected for processing: 1
  • app/views/RoomsListView/components/SectionRevealFooter.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Recent review details
Context from checks skipped due to timeout: 2
  • GitHub Check: Build Android / Upload Hold
  • GitHub Check: Build iOS / Hold
Additional context used
Code guidelines: 1
CLAUDE.md — auto-discovered
Path-based instructions: 1
Source excerpt: Local-first data flow: the UI reads from WatermelonDB, sagas sync it with the server.

CodeRabbit inference engine (CLAUDE.md)

Files:

  • app/views/RoomsListView/components/SectionRevealFooter.tsx
Additional comments: 1
app/views/RoomsListView/components/SectionRevealFooter.tsx: 1

31-32: LGTM!

Walkthrough

The section reveal cover style now sets opacity to 0. Its existing positioning remains unchanged.

Changes

Section reveal cover

Layer / File(s) Summary
Cover style update
app/views/RoomsListView/components/SectionRevealFooter.tsx
The cover style sets opacity to 0. Its existing right positioning remains.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: type: bug

Suggested reviewers: diegolmello

Merge Risk: Minimal · up to 5b7da

The cover remains hidden after the reveal without a known regression; the change is mergeable.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the Android regression addressed by the change: a blank block appearing over rooms after expanding a category.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Errors were encountered while retrieving linked issues.

Errors: 1
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Rohit3523
Rohit3523 deployed to approve_e2e_testing October 26, 2026 18:00 — with GitHub Actions Active
@Rohit3523

Copy link
Copy Markdown
Member Author

@coderabbitci review

@Rohit3523 Rohit3523 changed the title fix: blank block over rooms after expanding a category on Android regression: blank block over rooms after expanding a category on Android Oct 26, 2026
@github-actions

Copy link
Copy Markdown

@Rohit3523

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Rohit3523
Rohit3523 marked this pull request as ready for review October 27, 2026 09:20
@diegolmello
diegolmello merged commit e4d73e5 into develop Oct 27, 2026
26 of 31 checks passed
@diegolmello
diegolmello deleted the fix/android-category-expand-blank-block branch October 27, 2026 19:01
@diegolmello diegolmello changed the title regression: blank block over rooms after expanding a category on Android fic: blank block over rooms after expanding a category on Android Oct 27, 2026
@diegolmello diegolmello changed the title fic: blank block over rooms after expanding a category on Android fix: blank block over rooms after expanding a category on Android Oct 27, 2026

This branch is waiting to be deployed

1 active, 1 inactive, and 2 waiting deployments
upload_android — 5b7dab24 Waiting Oct 26, 2026 by Rohit3523 via Build Android / Upload Hold #7547
ios_build — 5b7dab24 Waiting Oct 26, 2026 by Rohit3523 via Build iOS / Hold #7547
android_build — 5b7dab24 Deployed Oct 26, 2026 by Rohit3523 via Build Android / Hold #7547
approve_e2e_testing — 5b7dab24 Deployed Oct 26, 2026 by Rohit3523 via E2E Hold #7547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants