Repository navigation
fix: blank block over rooms after expanding a category on Android - #7847
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Cover style update app/views/RoomsListView/components/SectionRevealFooter.tsx |
The cover style sets opacity to 0. Its existing right positioning remains. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- RocketChat/Rocket.Chat.ReactNative#7839: Changes the room-list section animation that uses the same Reanimated entering and exiting animations.
- RocketChat/Rocket.Chat.ReactNative#7831: Adds an end-to-end flow that exercises the section reveal path.
Suggested labels: type: bug
Suggested reviewers: diegolmello
Merge Risk: 
Minimal · up to 5b7da
-
The cover remains hidden after the reveal without a known regression; the change is mergeable.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Errors were encountered while retrieving linked issues.
Errors: 1
-
- JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitci review |
|
Android Build Available Rocket.Chat 4.78.0.110103 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNR7jvRgYgpM6dy0x9nRdGG93qGgat_MINwuRymMuLuJAFYatuR2TSP5e9PFJwfBHhiNgOYVlx69y26Ga88y |
|
@coderabbitai review |
✅ Action performed
|
Proposed changes
On Android, after collapsing and expanding a category in the rooms list, a blank block covered the rooms below the screen and stayed there after scrolling. The block is the cover in
SectionRevealFooterthat slides away to reveal the expanded rooms. It hides itself only at the end of its entering animation, and on Android Reanimated puts the view's style opacity (1) back once that animation ends. Settingopacity: 0in the cover's style keeps it hidden afterwards, and the reveal animation looks the same. The cover came in with #7707 (Liquid Glass).Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1806
How to test or reproduce
Screenshots
android-before.mp4
android-after.mp4
ios-before.mp4
ios-after.mp4
Types of changes
Checklist
Further comments
coverEnteringor patching Reanimated would both be bigger changes for the same result.pointerEvents: 'none'on the cover: after collapse, expand and scroll on Android, tapping a room that sat under the old blank block opens it, and swiping it shows its row actions.Summary by CodeRabbit