Repository navigation
chore: bump datetimepicker to 9.2.1 and slider to 5.2.1 - #7844
diegolmello wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update community package pins package.json |
The datetime picker version changed from 9.1.0 to 9.2.1. The slider version changed from 5.2.0 to 5.2.1. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested reviewers: rohit3523
Merge Risk: 
3f253
-
The dependency pins are consistent with the lockfile, and no actionable issue remains before merge.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names the two dependency bumps the PR makes: @react-native-community/datetimepickerfrom 9.1.0 to 9.2.1 and@react-native-community/sliderfrom 5.2.0 to 5.2.1. The raw summary confirms these…Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the two dependency bumps the PR makes:
@react-native-community/datetimepickerfrom 9.1.0 to 9.2.1 and@react-native-community/sliderfrom 5.2.0 to 5.2.1. The raw summary confirms these are the only changes in package.json, so the title matches the main change. It is specific, concise, and not vague.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Errors were encountered while retrieving linked issues.
Errors: 1
-
- JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
GitHub Actions
Inactive
GitHub Actions
Error
|
Android Build Available Rocket.Chat 4.78.0.110099 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSTx_Al9Y0zvm8C78p-83Bnx8_aeXZNsMqQ9ak81sNCEs5My0xcuXKsnLH1rBhZsHRvRbwYuJmhqnGpTa1O |
|
iOS Build Available Rocket.Chat 4.78.0.110100 |
GitHub Actions
Waiting
GitHub Actions
Waiting
GitHub Actions
Waiting
Proposed changes
Bumps
@react-native-community/datetimepicker9.1.0 → 9.2.1 and@react-native-community/slider5.2.0 → 5.2.1, the versions Expo SDK 58 pins, so they land ahead of the React Native 0.88 / Expo 58 upgrade.Neither changelog has a breaking change:
designchanges, Kotlin plugin skipped when AGP ships built-in Kotlin,DateTimePickerAndroid.dismisstyping.The datetimepicker Expo config plugin is not added to
app.json; the app doesn't need it.Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1830
How to test or reproduce
Date picker:
datepickersection accessory: tap "Select a date", pick a day. iOS highlights the picked day in the inline calendar; on Android, reopening the dialog shows the picked day selected.Slider: nothing in
app/imports it (the audio seek bar is built on gesture-handler and reanimated). It is only autolinked natively, so check that both platforms build and the app launches.Screenshots
Types of changes
Checklist
Further comments
@react-native-community/sliderhas no JS usage in the app. Removing it could be a follow-up.On iOS, the Status → Clear after → Set date and time sheet opens too short: only the first calendar week shows and Confirm is off screen. This already happens on develop: the iOS native code and iOS JS of the package are identical between 9.1.0 and 9.2.1.
Summary by CodeRabbit