[diegolmello]

Proposed changes

Bumps react-native-keyboard-controller from 1.18.5 to 1.22.9, pinned exactly.

The local patch react-native-keyboard-controller+1.18.5.patch is removed: it only made onConfigurationChanged take a non-null Configuration in EdgeToEdgeReactViewGroup.kt and KeyboardBackgroundViewGroup.kt, and 1.22.9 ships that signature upstream.

react-native-external-keyboard is unchanged.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1826

How to test or reproduce

• Android, with a hardware keyboard: open the app fresh, Tab through onboarding to the login form, and confirm focus moves through the server field, then email, password and submit.
• Android and iOS: open a room, tap the composer, type, then dismiss the keyboard. The composer stays above the keyboard while it opens and closes.
• Android: the keyboard navigation e2e flows (e2e/tests/keyboardNavigation: components, onboarding, room) pass on an emulator with hw.keyboard = yes.

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

The three Android keyboard navigation flows pass on CI with 1.22.9, with durations similar to 1.22.7 and 1.18.5. In one run the room flow passed only on retry, after its first attempt failed the initial focus check on the rooms list sidebar; a rerun passed with no retries.

1.22.9 rather than 1.22.7: on iOS, 1.22.7's KeyboardAwareScrollView swaps its scroll view's class to disable scrollRectToVisible and never restores it, so a recycled native scroll view can carry that into a later plain ScrollView. 1.22.9 restores the class on recycle.

On Android the composer moves slightly ahead of the keyboard animation (about 0.1–0.3 s) when it opens and closes; this was compared on 1.22.7 and is identical on 1.18.5, so it is not introduced here.

Summary by CodeRabbit

• Chores
  • Updated the keyboard controller to a newer release. No other user-facing changes are specified in this update.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7f11d2e5-d394-4677-9f60-7cdfec666522

Commits

Reviewing files that changed from the base of the PR and between e6fdcdf and 734b649.

Files ignored due to path filters: 2

• ios/Podfile.lock is excluded by !**/*.lock
• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing: 1

• package.json

Files skipped from review as they are similar to previous changes: 1

• package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

Recent review details

Context from checks skipped due to timeout: 2

• GitHub Check: ESLint and Test / run-eslint-and-test
• GitHub Check: E2E Shard Preflight

Walkthrough

The react-native-keyboard-controller dependency is upgraded from 1.18.5 to 1.22.9. The patch file for version 1.18.5 is removed.

Changes

Keyboard controller update

Layer / File(s)	Summary
Upgrade keyboard controller package.json, patches/react-native-keyboard-controller+1.18.5.patch	The dependency version changes to 1.22.9. The removed patch previously changed the onConfigurationChanged parameter type in two Android classes.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

• RocketChat/Rocket.Chat.ReactNative#7840: Adds an Expo install exclusion for the same dependency to preserve the version updated here.

Suggested labels: type: chore

Suggested reviewers: rohit3523

Merge Risk: Minimal · up to 734b6

The dependency update is ready to merge based on the inspected install and Android compatibility paths.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the dependency upgrade from 1.18.5 to 1.22.9. This matches the package change and commit message, although the PR description mentions 1.22.7.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Errors were encountered while retrieving linked issues.

Errors: 1

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

iOS Build Available

Rocket.Chat 4.78.0.110080

[github-actions]

Android Build Available

Rocket.Chat 4.78.0.110077

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNR4HgoI0ovWKKalMMfvl7adhSIAub0lu9roCCCUzGZ2ayAN50jjRmH_rTVJ4i7yqghMZfRWFFH08sryxkrc