Skip to content

ui: Honor header expansion in constrained previews - #682

Merged
Reddimus merged 2 commits into
mainfrom
fix/constrained-preview-expansion-44
Oct 28, 2026
Merged

Reddimus merged 2 commits into
mainfrom
fix/constrained-preview-expansion-44

Conversation

@Reddimus

Copy link
Copy Markdown
Owner

A preview forced into a strip by a small window could interpret its header's Expand button as Collapse. It then stayed collapsed after the window grew. Choose the requested state from the visible lane, using the existing expansion helper.

Validation: full just gauntlet; matching macOS and Linux release GUI/worker builds; native Linux card and viewer suites; native macOS collapse/expand and constrained-resize button checks. The regression covers ordinary menu collapse/expand and both menu and header-button expansion after resizing.

@github-actions github-actions Bot added the ui label Oct 27, 2026
@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: apex

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Header toggles now choose expand or collapse from the visible preview instead of its saved request.

  • Preview header buttons follow the lane’s visible state.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A["Header toggle"] --> B{"Visible preview is a strip?"}
  B -->|Yes| C["Save expanded = true"]
  B -->|No| D["Save expanded = false"]
  C --> E{"Enough room?"}
  E -->|Yes| F["Show expanded preview"]
  E -->|No| G["Keep strip and expansion request"]
  G -->|"Window grows"| F
  D --> H["Show collapsed strip"]
Loading

Reviews (2) · Last reviewed commit: "ui: Integrate current preview documentat..."

@Reddimus
Reddimus changed the base branch from docs/current-mux-guidance-43 to main October 28, 2026 00:32
@Reddimus
Reddimus merged commit c36355f into main Oct 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant