Repository navigation
feat: refresh Predictions contracts and harden transports - #75
Merged
Merged
Conversation
[High impact] The PR appears safe to merge; the previous findings are addressed and no new blocking issue was found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh Predictions OpenAPI 3.34.0 and AsyncAPI 2.0.0: 128 REST operations and 14 data channels, including ten explicitly documented prelaunch RFQ-batch operations. Preserve optional server timestamps and add successful request/response contracts for the new batch and FCM writes.
Harden full-input JSON validation, independent balance pacing, retry arithmetic, bounded HTTP/WebSocket bodies, signing inputs, and URL handling. Contain WebSocket internal failures without allocating during cleanup; preserve positive reconnect waits. Add portable Windows HTTP loopback tests and concise setup documentation, scoped tools, and review configuration. Prepare v0.7.0.
Validation: 334 native tests; 324 ASan/UBSan tests; 75 generator tests; 334 tests against system Glaze 8.3.0; format, explicit-type, code-generation, Markdown and clang-tidy checks; installed/FetchContent consumers and API docs. The sustained allocation-failure regression aborts with the old cleanup and passes with the fix, including client reuse. All required CI checks pass at 7c6f314, including Windows, Linux, macOS, ASan/UBSan, TSan and consumer builds; CodeQL passes. Independent code and final documentation reviews approved; the final external source review found no new issues.
Live public market data, Ed25519/RSA authenticated portfolio reads, and a WebSocket orderbook snapshot passed. No production writes were made. Demo order/cancel was not run because no demo credential was identified; prelaunch endpoints are validated offline against the published contract.