Repository navigation
Conversation
blaze0089
force-pushed
the
fix/include-exclude-args
branch
from
November 8, 2026 04:03
d607ff1 to
4cdd68b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #976.
-yand-xare declared withnum_args = 1.., which makes clap treat every following value as another signature.binwalk -y zip firmware.binparsesfirmware.binas a second include value, leavesfile_nameempty, and produces "No target file name specified". The--include=zipform works because the value is attached to the option.Removing
num_argsleaves the default of one value per occurrence. Comma-separated lists (-y zip,png) and repeated flags still work, and the positional file name is no longer swallowed.Added parser tests in
src/cliparser.rsfor-y zip firmware.bin,-y zip,png firmware.bin,-x zip firmware.bin, and--include=zip firmware.bin.Verified with
cargo test --bin binwalk(4 passed),cargo fmt --check, and the built binary: