Skip to content

test: use no_run for doctests requiring local files - #965

Open
Infraw wants to merge 1 commit into
ReFirmLabs:masterfrom
Infraw:fix-doctests-no-run
Open

Infraw wants to merge 1 commit into
ReFirmLabs:masterfrom
Infraw:fix-doctests-no-run

Conversation

@Infraw

@Infraw Infraw commented Aug 27, 2026

Copy link
Copy Markdown

I'm the package maintainer for binwalk in the Fedora Linux repositories.

Doctests in src/binwalk.rs currently fail in isolated build environments (like Fedora mock or CI sandboxes) because they depend on hardcoded local file paths (e.g., /bin/ls).

This PR adds the rust,no_run attribute to these specific examples. This allows Cargo to compile them for syntax validation while skipping execution, preventing false-positive test failures during Linux distro packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant