Repository navigation
feat(driver): add OnedriveAPP SharePoint field i18n - #724
Open
AkashiCoin wants to merge 1 commit into
Open
AkashiCoin wants to merge 1 commit into
AkashiCoin wants to merge 1 commit into
Conversation
- 新增 `is_sharepoint` 与 `is_sharepoint-tips`,说明该开关用于挂载 SharePoint 站点文档库而非用户 OneDrive - 新增 `site_id` 与 `site_id-tips`,说明支持站点 URL、`<host>:/sites/<name>` 与复合 ID 三种写法,并提示裸域名会落到默认文档库通常为空的根站点 Co-authored-by: Claude <81847+claude@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
OnedriveAPPgained two newAdditionfields in OpenListTeam/OpenList#3252:is_sharepointandsite_id. This PR adds the matchingdrivers.jsonentries so the field labels and help text render properly instead of falling back to auto-formatted keys.User-visible behavior changes:
is_sharepointnow shows asIs sharepointwith an explanation that it mounts a SharePoint site's document library instead of a user's OneDrive.site_idnow shows asSite idwith a hint listing the three accepted formats and warning that a bare host resolves to the root site, whose default library is usually empty.Important implementation changes:
Four keys added to the
OnedriveAPPblock insrc/lang/en/drivers.json:is_sharepoint,is_sharepoint-tips,site_id,site_id-tips.Wording is kept consistent with the existing
Onedrivedriver, which already has these two fields.Translations for other locales are left to Crowdin, per
crowdin.yml(source: /src/lang/en/*.json).This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Note: the fields themselves come from the backend PR above. Without it these keys are simply unused; nothing breaks.
Related Issues / 关联 Issue
Relates to OpenListTeam/OpenList#3252
Testing / 测试
Not run:
go test ./...— not applicable, this repository is a SolidJS frontend.Commands run:
Manual verification:
src/lang/en/drivers.jsonwith the same nesting the app uses and confirmed all four keys resolve:drivers.OnedriveAPP.is_sharepoint,drivers.OnedriveAPP.is_sharepoint-tips,drivers.OnedriveAPP.site_id,drivers.OnedriveAPP.site_id-tips.src/pages/manage/storages/Item.tsx: the label comes fromdrivers.<driver>.<name>and the help line fromdrivers.<driver>.<name>-tips, so both the label and the hint are covered.Not covered:
The form was not rendered in a running instance against the patched backend, so the visual result was not verified end to end.
bun run lintreports 13error TSinMonacoEditor.tsx,archive.tsx,text-editor.tsx,video.tsxandAddOrEdit.tsx. The same 13 errors occur on unmodifiedmain(git stashcomparison), so they are pre-existing and unrelated to this change.go test ./...Manual test / 手动测试:
Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI-assisted 提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。