Repository navigation
fix(ci): verify MSI after successful reboot-required status 3010 - #1215
Merged
Merged
Conversation
Collaborator
Author
|
Reviewed 0-only default and explicit MSI-only 3010 success, unchanged failure/registry assertions, immutable test tooling pin, and separate application tag checkout. Windows cloud tests ran six cases against actual PowerShell helper definitions; exact head 28b8e35 CI 38893972870 passed 7/7. Administrator fast-forward, then Windows-only draft repair. 3010 is not by itself acceptance: all real installed payload/COM/TSF assertions must still pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart Manager isolation now keeps the runner alive; Windows-only repair 38889597557 reaches MSI success-with-reboot-required (3010), incorrectly rejected by the old smoke helper. Default remains 0-only; explicitly allow 3010 for MSI install/uninstall only, then run every existing payload/COM/TSF/registry assertion. NSIS remains strict; actual failures and initiated-reboot 1641 remain rejected. Windows CI executes six mocked exit-code cases against actual helper definitions without installs. Sparse checkout the test-only smoke script pinned to github.workflow_sha, keeping compiled app source fixed to immutable release tag. Failure cache preserves completed compilation. Local MSI/package/publication contracts pass; wait exact-head CI before guarded Windows-only repair. No release tag/app payload/version changes.