[idris-domatix]

Migration of web_sheet_full_width to 19.0

Standard migration. Module history ported from 16.0.

Migration changes:

• Manifest version bumped to 19.0.1.0.0, and assets moved from the removed web.assets_common bundle to web.assets_backend (the common bundle was split in 19.0).
• SCSS: chatter selector .o_FormRenderer_chatterContainer → .o-mail-Form-chatter (renamed in 19.0).
• Removed the <?xml ?> declaration from static/description/index.html (in 19.0 it breaks description_html computation and prevents the module from installing).
• Added pyproject.toml (whool).

Validation (local, without demo, mirroring CI):

• pre-commit green.
• Install with --test-enable --without-demo=all: clean, module loads without traceback.
• Browser smoke: form sheet renders full-width above the default 1140px limit.

No Python tests in this module.

[dreispt]

In English please

[BhaveshHeliconia]

I tested it locally and on runboat, but the functionality is not working.

[idris-domatix]

Thanks for the review.

@BhaveshHeliconia the module was not working because, since v17, the sheet max-width is set on .o_form_sheet_bg and no longer on .o_form_sheet. The SCSS was still overriding .o_form_sheet, so it had no effect on the sheet width.

Fixed by targeting .o_form_sheet_bg. Verified on a 19.0 instance with Playwright on a res.partner form:

• before: sheet width 1400px on a 1920px viewport (core max-width still applied)
• after: sheet width 1920px on a 1920px viewport (full width)

Also translated the SCSS and manifest comments to English, as requested.

[BhaveshHeliconia]

Functional review LGTM!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[dreispt]

I'm sorry, the module commit history is missing!
We should have the history until 18.0 and then the 19.0 migration specific commits as per migration wiki instructions.

[BhaveshHeliconia]

@idris-domatix Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0.

[idris-domatix]

Thanks @dreispt and @BhaveshHeliconia. I had squashed the whole module into a single commit, which was wrong.

I have restored the module commit history and rebased to fixup only the administrative commits into the contributor commit that generated them:

• [UPD] Update *.pot, [UPD] README.rst, the version bumps (14.0.1.0.1, 15.0.1.0.1) and Update translation files are now squashed.
• Translation commits are preserved.
• The [19.0][MIG] commit now also includes the SCSS fix (target .o_form_sheet_bg) and the English comments.

Note: in OCA/web this module was only present up to 16.0 (there is no 17.0/18.0 branch for web_sheet_full_width), so the preserved history ends at the 16.0 migration. The functional fix has been verified on a 19.0 instance (sheet width goes from 1400px to full width).

[dreispt]

I see a glitch when testing on Runboat - the form width does not follow the screen width when resizing.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[idris-domatix]

Thanks @dreispt, good catch.

The glitch appears when web_chatter_position is installed with the chatter position set to "bottom" (which is the case on Runboat). In that configuration web_chatter_position adds the o_fullwidth class to .o_form_sheet_bg and sets width: auto !important on it. Combined with the core margin-right: auto, the sheet shrank to its content width instead of using the whole available width.

Fixed by also resetting margin-right: 0 !important on .o_form_sheet_bg.

Verified locally reproducing the Runboat setup (CRM opportunity form, web_chatter_position = bottom, resizing the viewport):

• before: 1200px viewport → sheet 880px, 1000px → 880px
• after: 1200px → 1200px, 1000px → 1000px (full width at every size)

The commit history is preserved; the change is part of the [19.0][MIG] commit.

[CristianoMafraJunior]

Commit naming: fix from [19.0][MIG] web_sheet_full_width: Migration to 19.0 to [MIG] web_sheet_full_width: Migration to 19.0

[idris-domatix]

Will fix the commit subject to [MIG] web_sheet_full_width: Migration to 19.0 in the next push.

[idris-domatix]

Gentle nudge on this one when there's a window. @dreispt

[idris-domatix]

Thanks for the review. The migration commit subject has been updated to [MIG] web_sheet_full_width: Migration to 19.0; the module history (up to 16.0) and the tree are unchanged. @CristianoMafraJunior @dreispt, could you take another look when you have a moment?

[CristianoMafraJunior]

The title is reverting to the old default

[lucaorioli]

Functional test on a 19.0 instance, also together with web_chatter_resizable (#3775): the two modules work well together.

Up to 2600px wide the sheet now uses the whole width: forms without chatter, forms with the chatter below, and forms where the side chatter is hidden.

On a wider screen the form still stops at 2600px: core also limits .o_form_renderer ($o-form-renderer-max-width, web/static/src/views/form/form_controller.scss), which contains the sheet. This rule removes it, tested locally:

.o_form_view {
    .o_form_renderer {
        max-width: none;
    }
}

Would you add it, so the module is "full width" on wide screens too?