Skip to content

[18.0][IMP] account_financial_report: Add column options to the report wizards - #1569

Open
carlosdauden wants to merge 1 commit into
OCA:18.0from
Tecnativa:18.0-FIX-account_financial_report_column_config
Open

carlosdauden wants to merge 1 commit into
OCA:18.0from
Tecnativa:18.0-FIX-account_financial_report_column_config

Conversation

@carlosdauden

Copy link
Copy Markdown
Contributor

15.0 and 16.0 have the option to choose which columns show on the reports and to limit the width of some texts, but it never reached 17.0 or 18.0: the forward-port to 18.0 only carried the initial label_text_limit commit and left out the ones that added the columns model.

Restores the account.financial.report.column model, its view and its data, and turns the wizard's single label_text_limit field into a per-column configurable limit. The General Ledger, Open Items and Journal Ledger wizards gain a "Columns" page. Compared to the original, fixes the foreing_currency_visible typo in the Journal Ledger header, which misaligned the currency columns, and omits the analytic-tags column since it's not supported in 18.0.

@Tecnativa
@sergio-teruel @carlos-lopez-tecnativa

@carlosdauden
carlosdauden force-pushed the 18.0-FIX-account_financial_report_column_config branch from 2840ff7 to c6c39bc Compare September 9, 2026 10:19
@OCA-git-bot OCA-git-bot added mod:account_financial_report Module account_financial_report series:18.0 labels Sep 9, 2026
@carlosdauden
carlosdauden force-pushed the 18.0-FIX-account_financial_report_column_config branch from c6c39bc to 6fa2bd9 Compare September 9, 2026 16:06

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I couldn't test these changes because I got this error when I tried to open the wizard.
Image

@carlosdauden
carlosdauden force-pushed the 18.0-FIX-account_financial_report_column_config branch from 6fa2bd9 to a327a6a Compare September 15, 2026 10:06
@carlosdauden

Copy link
Copy Markdown
Contributor Author

Changes done

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the option to add a new line because it displays columns that are not part of the report model. Alternatively, we could add a domain based on the report model. What do you think?

Image

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I noticed that these options are applied to the view and PDF, but they don't work in Excel. Is this the expected behavior, or should they also work in Excel?

@carlosdauden
carlosdauden force-pushed the 18.0-FIX-account_financial_report_column_config branch from a327a6a to 2dd21b9 Compare September 16, 2026 16:19
@carlosdauden

Copy link
Copy Markdown
Contributor Author

Changes done

<field name="model">account.financial.report.column</field>
<field name="arch" type="xml">
<list editable="bottom" create="false" delete="false">
<field name="sequence" widget="handle" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the sequence field?

Personally, I would remove this field. As a user, I might think that the order in which I arrange the fields determines the order in which they are rendered in the report, but this doesn't seem to be the case. Therefore, I don't see any utility in having this field.

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in this version, included in 20.0

@CarlosRoca13
CarlosRoca13 force-pushed the 18.0-FIX-account_financial_report_column_config branch 2 times, most recently from 81a41ac to 83ab1a6 Compare September 30, 2026 14:51
@CarlosRoca13
CarlosRoca13 force-pushed the 18.0-FIX-account_financial_report_column_config branch from 83ab1a6 to 69879b6 Compare October 13, 2026 06:57
15.0 and 16.0 have the option to choose which columns show on the reports and to limit the width of some texts, but it never reached 17.0 or 18.0: the forward-port to 18.0 only carried the initial `label_text_limit` commit and left out the ones that added the columns model.

Restores the `account.financial.report.column` model, its view and its data, and turns the wizard's single `label_text_limit` field into a per-column configurable limit. The General Ledger, Open Items and Journal Ledger wizards gain a "Columns" page. Compared to the original, fixes the `foreing_currency_visible` typo in the Journal Ledger header, which misaligned the currency columns, and omits the analytic-tags column since it's not supported in 18.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:account_financial_report Module account_financial_report series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants