Repository navigation
fix(plugins): guard plugin-http readBody against stream errors and closed responses - #1606
Open
swiezaczek wants to merge 1 commit into
Open
swiezaczek wants to merge 1 commit into
swiezaczek wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard
readBody()inservices/plugin-http.cjsagainst streamerrorevents and double settlement, and centralize response-closed checks inisResponseClosed()(writableEnded || finished || destroyed) for Node 4.4.3 / Node 8 compatibility.PR type
Affected area
Why
On Node 4.4.3 (Tizen) and Node 8 (webOS),
response.writableEndedisundefined(added in Node 12.9.0), andreadBody()lacked anerrorlistener andsettledguard.Issue or approval
Fixes #1603
Reproduction steps
plugin-http.cjswhere the incoming stream emitserrorbeforeend, or checkresponse.writableEndedon Node 4.4.3 / Node 8.Old behavior
readBody()could hang or settle twice on stream errors, andwritableEndedwasundefinedon legacy Node.New behavior
isResponseClosed(response)checksresponse.writableEnded || response.finished || response.destroyedand socket destruction.readBody()uses asettledguard and attachesrequest.on("error").Platform impact
UI / behavior / playback impact
Installer, packaging, or wrapper impact
.wgtpackaging changed.ipkpackaging changedlocal.properties/ environment handling changedsync:tizenchangedsync:weboschangedPolicy check
CONTRIBUTING.md.Scope boundaries
Strictly limited to
services/plugin-http.cjsstream/response guards.package.jsonis left untouched to avoid conflicts with concurrent PRs.Testing
Devices / platforms tested
test-plugin-http-readbody-and-closed.mjs.Commands tested
Manual test flow
test-plugin-http-readbody-and-closed.mjs(1/1 passing).Screenshots / Video
Not a UI change
Logs
Not applicable
Regression risk
Low. Preserves existing Node 12+
writableEndedchecks while addingfinishedfallback for Node 4.4.3 / Node 8.Breaking changes
None.
Linked issues
Fixes #1603