Skip to content

fix(p2p): gate P2P cache controls by TizenCapabilities.canUseP2p() - #1605

Open
swiezaczek wants to merge 1 commit into
NuvioMedia:mainfrom
swiezaczek:fix/p2p-gate-cache-controls-by-tizen-capabilities
Open

swiezaczek wants to merge 1 commit into
NuvioMedia:mainfrom
swiezaczek:fix/p2p-gate-cache-controls-by-tizen-capabilities

Conversation

@swiezaczek

Copy link
Copy Markdown
Contributor

Summary

Gate P2pCacheService.supportsCacheControls() on TizenCapabilities.canUseP2p() so Tizen < 5.0 runtimes without EngineFS P2P support do not expose P2P cache controls.

PR type

  • Translation/localization only
  • Critical bug fix
  • Approved feature/change

Affected area

  • Shared web app
  • Samsung Tizen
  • LG webOS
  • Browser development mode
  • Playback
  • Audio tracks
  • Subtitles
  • Focus / Remote navigation
  • UI / Layout
  • Resume / Watch progress
  • Continue Watching
  • Next Episode / Auto-play
  • Packaging / Build
  • Nuvio TV Installer compatibility
  • webOS Homebrew wrapper
  • Documentation
  • Other

Why

Tizen < 5.0 does not support EngineFS P2P, so returning Platform.isTizen() unconditionally exposed cache controls on unsupported Tizen versions.

Issue or approval

Fixes #1602

Reproduction steps

  1. Run on Tizen < 5.0 (TizenCapabilities.canUseP2p() === false).
  2. Call P2pCacheService.supportsCacheControls().

Old behavior

P2pCacheService.supportsCacheControls() returned Platform.isTizen() (true on Tizen < 5.0).

New behavior

P2pCacheService.supportsCacheControls() returns TizenCapabilities.canUseP2p().

Platform impact

  • Samsung Tizen: Disables P2P cache controls on Tizen < 5.0; Tizen >= 5.0 unchanged.
  • LG webOS: No impact (canUseP2p() is false).
  • Browser development mode: No impact.
  • Installer / packaging: No impact.
  • Wrapper repositories: No impact.

UI / behavior / playback impact

  • No UI change
  • No behavior change
  • No playback change
  • UI changed only to fix a documented glitch/bug
  • Behavior changed only to fix a documented bug/regression
  • Playback changed only to fix a documented bug/regression
  • UI change has explicit maintainer approval
  • Behavior change has explicit maintainer approval
  • Playback change has explicit maintainer approval

Installer, packaging, or wrapper impact

  • No installer, packaging, or wrapper impact
  • Tizen .wgt packaging changed
  • webOS .ipk packaging changed
  • App identifiers or metadata changed
  • local.properties / environment handling changed
  • sync:tizen changed
  • sync:webos changed
  • Nuvio TV Installer compatibility changed
  • webOS Homebrew metadata support changed

Policy check

  • I have read and understood CONTRIBUTING.md.
  • This PR fits the current PR policy or has explicit maintainer approval.
  • This PR is small, focused, and limited to one issue.
  • This PR does not bundle unrelated refactors, cleanups, formatting, or drive-by changes.
  • This PR does not add dependencies, architecture changes, platform rewrites, installer rewrites, or broad refactors without approval.
  • This PR does not change UI unless it fixes a linked glitch/bug or has explicit approval.
  • This PR does not change behavior unless it fixes a linked bug/regression or has explicit approval.
  • This PR does not change playback unless it fixes a linked bug/regression or has explicit approval.
  • This PR does not change installer, packaging, app identifiers, release flow, or wrapper behavior without clear need or approval.
  • I included a linked issue, reproduction steps, and testing notes if this is a critical bug fix.
  • I listed the testing performed below.

Scope boundaries

Strictly limited to P2pCacheService.supportsCacheControls(). package.json is left untouched to avoid conflicts with concurrent PRs.

Testing

Devices / platforms tested

  • Verified locally on Windows (Node v24.13.0) with Prettier, ESLint, and p2pCacheServiceCapabilities.test.mjs; not tested on physical Tizen < 5.0 hardware.

Commands tested

npx --no-install prettier --check js/core/p2p/p2pCacheService.js js/core/p2p/p2pCacheServiceCapabilities.test.mjs
npx --no-install eslint --quiet js/core/p2p/p2pCacheService.js js/core/p2p/p2pCacheServiceCapabilities.test.mjs
node --test js/core/p2p/p2pCacheServiceCapabilities.test.mjs

Manual test flow

  • Ran p2pCacheServiceCapabilities.test.mjs (1/1 passing).

Screenshots / Video

Not a UI change

Logs

Not applicable

Regression risk

Low. Tizen >= 5.0 still returns true from TizenCapabilities.canUseP2p().

Breaking changes

None.

Linked issues

Fixes #1602

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: P2pCacheService.supportsCacheControls exposes cache controls on Tizen < 5.0

1 participant