Repository navigation
fix(navigation): reset stuck active Back/key state on window blur and document hidden - #1604
Open
swiezaczek wants to merge 1 commit into
Open
swiezaczek wants to merge 1 commit into
swiezaczek wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clear
activeBackKeyIdentitiesandactiveKeyDownStartedAtinFocusEngineonwindowbluranddocumentvisibilitychange(whendocument.hidden) so held keys cannot stay stuck after focus loss.PR type
Affected area
Why
If
windowloses focus or the app is backgrounded while a Back or directional key is held,keyupmay never fire, leavingactiveBackKeyIdentitiesandactiveKeyDownStartedAtstale.Issue or approval
Fixes #1601
Reproduction steps
FocusEngine.windowblurorvisibilitychange(document.hidden === true) beforekeyup.activeBackKeyIdentitiesandactiveKeyDownStartedAtstill hold the stale entry.Old behavior
FocusEngineonly cleared key tracking onkeyup.New behavior
FocusEngine.init()attachesblurandvisibilitychangelisteners (anddestroy()removes them) that clearactiveBackKeyIdentitiesandactiveKeyDownStartedAt.Platform impact
FocusEnginelifecycle.FocusEnginelifecycle.UI / behavior / playback impact
Installer, packaging, or wrapper impact
.wgtpackaging changed.ipkpackaging changedlocal.properties/ environment handling changedsync:tizenchangedsync:weboschangedPolicy check
CONTRIBUTING.md.Scope boundaries
Strictly limited to
FocusEngineblur/visibilitychangekey-state cleanup.package.jsonis left untouched to avoid conflicts with concurrent PRs.Testing
Devices / platforms tested
focusEngineBlurReset.test.mjs.Commands tested
Manual test flow
focusEngineBlurReset.test.mjs(1/1 passing).Screenshots / Video
Not a UI change
Logs
Not applicable
Regression risk
Low. Only clears active key tracking when the window blurs or becomes hidden.
Breaking changes
None.
Linked issues
Fixes #1601