Skip to content

fix(player): keep the post-play window resized on Tizen - #1600

Merged
WhiteGiso merged 1 commit into
mainfrom
fix/1599-tizen-post-play-surface
Nov 22, 2026
Merged

WhiteGiso merged 1 commit into
mainfrom
fix/1599-tizen-post-play-surface

Conversation

@WhiteGiso

@WhiteGiso WhiteGiso commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Summary

Keep the native playback surface in the post-play mini window on Tizen, and stop the credits skip action from running behind the recommendation overlay. applyAspectMode() no longer restores full screen while post-play owns the player, AVPlay display-rect updates are held until seekTo() settles, and the skip interval is cleared while the recommendation is visible, matching Android TV.

PR type

  • Translation/localization only
  • Critical bug fix
  • Approved feature/change

Affected area

  • Shared web app
  • Samsung Tizen
  • LG webOS
  • Browser development mode
  • Playback
  • Audio tracks
  • Subtitles
  • Focus / Remote navigation
  • UI / Layout
  • Resume / Watch progress
  • Continue Watching
  • Next Episode / Auto-play
  • Packaging / Build
  • Nuvio TV Installer compatibility
  • webOS Homebrew wrapper
  • Documentation
  • Other

Why

On Tizen the post-play mini window is a small AVPlay display rect behind an HTML mask cut out of the recommendation backdrop. When a playback lifecycle event fired while the overlay was open (canplay after the credits skip seek, a track change, resume), applyAspectMode() restored the full-screen display rect. The mask then showed a cropped fragment of the full-size frame instead of a scaled movie. The same skip seek started while the post-play tween was calling setDisplayRect/setDisplayMethod; AVPlay forbids other calls until seekTo() reports back, which left the native player stuck for a while.

Issue or approval

Fixes #1599

Reproduction steps

  1. On Samsung Tizen, open a movie with end-credits metadata (the report used Love Actually).
  2. Let the credits start so the post-play recommendation overlay appears.
  3. Play through the credits, or trigger the credits Skip button while the recommendation loads.
  4. Observe the small window: it shows a cropped portion of the full-size credits instead of the whole frame, and the skip click can freeze playback.

Old behavior

applyAspectMode() always reapplied the full-screen AVPlay rect, so the mini window lost its geometry. The credits skip interval stayed active and focusable under the recommendation overlay, and its seek could run while the mini tween issued AVPlay calls during an in-flight seek.

New behavior

The post-play window keeps its 32% x 16:9 rect and the selected aspect handling (FIT by default) until the user returns to the player. Display-rect changes requested during a seek are applied from the seek callback. The skip interval is cleared while the recommendation is visible, so the button cannot start a seek behind the overlay, matching Android TV.

Platform impact

  • Samsung Tizen: the AVPlay display rect and seek sequencing are fixed; the mini window now keeps the selected aspect mode instead of forcing a stretched full-frame method.
  • LG webOS: shared player code; the post-play surface is no longer overridden by an aspect refresh, and the skip button follows the same post-play visibility rule. No native webOS calls were added.
  • Browser development mode: same shared geometry rule, no behavior change outside post-play.
  • Installer / packaging: not touched.
  • Wrapper repositories: not touched.

UI / behavior / playback impact

  • No UI change
  • No behavior change
  • No playback change
  • UI changed only to fix a documented glitch/bug
  • Behavior changed only to fix a documented bug/regression
  • Playback changed only to fix a documented bug/regression
  • UI change has explicit maintainer approval
  • Behavior change has explicit maintainer approval
  • Playback change has explicit maintainer approval

Installer, packaging, or wrapper impact

  • No installer, packaging, or wrapper impact
  • Tizen .wgt packaging changed
  • webOS .ipk packaging changed
  • App identifiers or metadata changed
  • local.properties / environment handling changed
  • sync:tizen changed
  • sync:webos changed
  • Nuvio TV Installer compatibility changed
  • webOS Homebrew metadata support changed

Policy check

  • I have read and understood CONTRIBUTING.md.
  • This PR fits the current PR policy or has explicit maintainer approval.
  • This PR is small, focused, and limited to one issue.
  • This PR does not bundle unrelated refactors, cleanups, formatting, or drive-by changes.
  • This PR does not add dependencies, architecture changes, platform rewrites, installer rewrites, or broad refactors without approval.
  • This PR does not change UI unless it fixes a linked glitch/bug or has explicit approval.
  • This PR does not change behavior unless it fixes a linked bug/regression or has explicit approval.
  • This PR does not change playback unless it fixes a linked bug/regression or has explicit approval.
  • This PR does not change installer, packaging, app identifiers, release flow, or wrapper behavior without clear need or approval.
  • I included a linked issue, reproduction steps, and testing notes if this is a critical bug fix.
  • I listed the testing performed below.

Scope boundaries

No refactors, no CSS restyling, no packaging, wrapper, dependency, or architecture changes. The credits trigger, recommendation content, overlay layout, and post-play navigation are untouched. Zoom-specific AVPlay limitations are unchanged; the mini window follows the same display method the full-screen player already uses.

Testing

Devices / platforms tested

Static and automated verification in the repository: Node test scripts covering the player screen, AVPlay display geometry, AVPlay seek sequencing, seek loading, chapter skip, and the post-play episode metadata. No physical Tizen or webOS device was available in this environment.

Commands tested

node scripts/test-live-player-controls.mjs
node scripts/test-tizen-avplay-seek-sequencing.mjs
node scripts/test-tizen-seek-loading.mjs
node scripts/test-tizen-hls-subtitle-viewport.mjs
node scripts/test-parity-chapter-skip.mjs
node scripts/test-movie-end-credits-chapters.mjs
node tests/playerOverlayFocus.test.mjs
npm test
npx eslint <touched files> --quiet --rule "no-unused-vars: off"
npx prettier --check <touched files>

Manual test flow

The automated harness covers the exact sequence: post-play visible -> display-rect update -> AVPlay seek in flight -> deferred rect -> seek callback applies the mini rect; plus the skip button clearing on post-play visibility and the aspect surface remaining untouched. The issue video in #1599 is the broken reference; the expected state is the whole frame scaled into the top-right 16:9 window with the selected aspect handling.

Screenshots / Video

Broken-state video is attached to #1599. A new capture requires a Tizen device; the automated checks verify the geometry handoff and the skip-button state instead.

Logs

Not applicable as a device log: the failure is the native AVPlay display geometry, and the relevant sequencing is covered by scripts/test-tizen-avplay-seek-sequencing.mjs instead of a runtime log.

Regression risk

Display-rect deferral affects Tizen seeks: the held rect is applied from the same callback that already resumes playback, and teardown clears the pending flag. The aspect guard only applies while the post-play overlay is visible; returning to the player restores the normal aspect surface. webOS uses the HTML video path and the shared guard; no native webOS call was added. Skip button visibility outside post-play is unchanged.

Breaking changes

None.

Linked issues

Fixes #1599

The credits mini window kept its native AVPlay surface full screen. Any
lifecycle refresh during post-play (canplay after the skip seek, a track
change) ran applyAspectMode, which restored the full-screen display rect
under the recommendation overlay and left a cropped fragment in the mask
hole.

- applyAspectMode leaves the playback surface alone while the post-play
  window owns it.
- The mini window keeps the selected aspect mode inside its own rect
  instead of forcing a stretched full-screen method.
- AVPlay display changes wait for seekTo() to settle, as Samsung requires,
  and are applied from the seek callback.
- The skip interval is cleared during post-play, like Android TV, so the
  skip button cannot start a seek under the recommendation overlay.
@WhiteGiso
WhiteGiso merged commit 7006c6a into main Nov 22, 2026
1 of 2 checks passed
@WhiteGiso
WhiteGiso deleted the fix/1599-tizen-post-play-surface branch November 22, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Video not resized in the credits recommendations

1 participant