Repository navigation
fix(player): keep the post-play window resized on Tizen - #1600
Merged
Merged
Conversation
The credits mini window kept its native AVPlay surface full screen. Any lifecycle refresh during post-play (canplay after the skip seek, a track change) ran applyAspectMode, which restored the full-screen display rect under the recommendation overlay and left a cropped fragment in the mask hole. - applyAspectMode leaves the playback surface alone while the post-play window owns it. - The mini window keeps the selected aspect mode inside its own rect instead of forcing a stretched full-screen method. - AVPlay display changes wait for seekTo() to settle, as Samsung requires, and are applied from the seek callback. - The skip interval is cleared during post-play, like Android TV, so the skip button cannot start a seek under the recommendation overlay.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the native playback surface in the post-play mini window on Tizen, and stop the credits skip action from running behind the recommendation overlay.
applyAspectMode()no longer restores full screen while post-play owns the player, AVPlay display-rect updates are held untilseekTo()settles, and the skip interval is cleared while the recommendation is visible, matching Android TV.PR type
Affected area
Why
On Tizen the post-play mini window is a small AVPlay display rect behind an HTML mask cut out of the recommendation backdrop. When a playback lifecycle event fired while the overlay was open (
canplayafter the credits skip seek, a track change, resume),applyAspectMode()restored the full-screen display rect. The mask then showed a cropped fragment of the full-size frame instead of a scaled movie. The same skip seek started while the post-play tween was callingsetDisplayRect/setDisplayMethod; AVPlay forbids other calls untilseekTo()reports back, which left the native player stuck for a while.Issue or approval
Fixes #1599
Reproduction steps
Old behavior
applyAspectMode()always reapplied the full-screen AVPlay rect, so the mini window lost its geometry. The credits skip interval stayed active and focusable under the recommendation overlay, and its seek could run while the mini tween issued AVPlay calls during an in-flight seek.New behavior
The post-play window keeps its 32% x 16:9 rect and the selected aspect handling (FIT by default) until the user returns to the player. Display-rect changes requested during a seek are applied from the seek callback. The skip interval is cleared while the recommendation is visible, so the button cannot start a seek behind the overlay, matching Android TV.
Platform impact
UI / behavior / playback impact
Installer, packaging, or wrapper impact
.wgtpackaging changed.ipkpackaging changedlocal.properties/ environment handling changedsync:tizenchangedsync:weboschangedPolicy check
CONTRIBUTING.md.Scope boundaries
No refactors, no CSS restyling, no packaging, wrapper, dependency, or architecture changes. The credits trigger, recommendation content, overlay layout, and post-play navigation are untouched. Zoom-specific AVPlay limitations are unchanged; the mini window follows the same display method the full-screen player already uses.
Testing
Devices / platforms tested
Static and automated verification in the repository: Node test scripts covering the player screen, AVPlay display geometry, AVPlay seek sequencing, seek loading, chapter skip, and the post-play episode metadata. No physical Tizen or webOS device was available in this environment.
Commands tested
Manual test flow
The automated harness covers the exact sequence: post-play visible -> display-rect update -> AVPlay seek in flight -> deferred rect -> seek callback applies the mini rect; plus the skip button clearing on post-play visibility and the aspect surface remaining untouched. The issue video in #1599 is the broken reference; the expected state is the whole frame scaled into the top-right 16:9 window with the selected aspect handling.
Screenshots / Video
Broken-state video is attached to #1599. A new capture requires a Tizen device; the automated checks verify the geometry handoff and the skip-button state instead.
Logs
Not applicable as a device log: the failure is the native AVPlay display geometry, and the relevant sequencing is covered by
scripts/test-tizen-avplay-seek-sequencing.mjsinstead of a runtime log.Regression risk
Display-rect deferral affects Tizen seeks: the held rect is applied from the same callback that already resumes playback, and teardown clears the pending flag. The aspect guard only applies while the post-play overlay is visible; returning to the player restores the normal aspect surface. webOS uses the HTML video path and the shared guard; no native webOS call was added. Skip button visibility outside post-play is unchanged.
Breaking changes
None.
Linked issues
Fixes #1599