Repository navigation
fix(home): name the media-server resume row after its server - #1594
Merged
WhiteGiso merged 2 commits intoNov 22, 2026
Merged
Conversation
The "Continue watching" row of a media server mixes movies and series, but its catalog type is "movie", so Home and the reorder screen titled it "Continue watching - Movie". The row is now named "Continue watching - <server name>" and gets no type suffix. Library rows and addon rows keep their titles.
Use "<server> · Continue watching" as Android does, still without the type suffix because the row mixes movies and series. Stub the helper in the tests that run the renderer in a VM, and cover the rendered title.
Member
|
Adjusted the row name to Android's format: Re-ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Continue watching" row of a media server is now titled "Continue watching - " and gets no type suffix, on Home and in Reorder home catalogs. Before, it read "Continue watching - Movie" also when it held series. Library rows and addon rows keep their titles.
PR type
Affected area
Why
The resume catalog has to declare one type and declares
movie, while it mixes movies and series.formatCatalogRowTitle()appends the type label to every row (when the suffix setting is on), and the reorder screen always appends it, so the row is labelled "Movie". Naming it after the server also tells two servers apart.Issue or approval
Fixes #1593
Reproduction steps
Old behavior
"Continue watching - Movie" on Home and in the reorder screen.
New behavior
"Continue watching - Emby" (the connection name) on Home and in the reorder screen. "TV shows - Series", "Movies - Movie" and addon rows are unchanged.
Platform impact
Shared code with no platform API involved.
UI / behavior / playback impact
Installer, packaging, or wrapper impact
.wgtpackaging changed.ipkpackaging changedlocal.properties/ environment handling changedsync:tizenchangedsync:weboschangedPolicy check
CONTRIBUTING.md.Scope boundaries
Only the resume row's name and its type suffix changed. Not touched: its order key, disable key and hero key (built from addon id, type and catalog id, not from the name), the catalog type, the server name order (Android uses "Emby · Continue watching"; this keeps the TV's " - " form), and the library rows.
package.jsononly registers the new test innpm test.Testing
scripts/test-media-server-resume-row-title.mjs(3 cases): the resume catalog is named after the server, it gets no type suffix, library and addon rows keep it. All three fail onmain.Devices / platforms tested
Browser development mode (Chrome 158 on Windows 11, 1920x1080). Not run on a TV with this branch, and not tested on LG webOS.
Commands tested
node --test scripts/test-media-server-resume-row-title.mjs scripts/test-catalog-order-media-server-rows.mjs scripts/test-media-server-resume-series.mjs scripts/test-media-server-sync.mjs js/ui/screens/home/continueWatchingSeriesIdentity.test.mjs js/core/profile/mediaServerSyncScope.test.mjs npm run lint npm run build npm testIn
npm test, the tests injs/ui/screens/home/homeHeroBackdropBitmap.test.mjsfail or pass between runs on the same code, also onmainwithout this change; that file does not touch media servers.Manual test flow
Connect Emby → start an episode → Home; then Settings → Content & Discovery → Addons → Reorder home catalogs.
Screenshots / Video
Home, before (

main):Home, after:

Reorder home catalogs, before (

main):Reorder home catalogs, after:

Logs
Not applicable.
Regression risk
Low. The row keys do not contain the name, so order, disabled marks, custom titles and hero selection are kept. The only key built from the name is the legacy disable key that Home still accepts for a row, but no screen stores it for media-server rows: since #1591 the reorder screen stores the order key for them, and the phone management page does not list media-server rows. Nothing is pushed to the account for these rows.
Breaking changes
None.
Linked issues
Fixes #1593