Skip to content

fix(home): name the media-server resume row after its server - #1594

Merged
WhiteGiso merged 2 commits into
NuvioMedia:mainfrom
tdrkmn:fix/media-server-resume-row-title
Nov 22, 2026
Merged

WhiteGiso merged 2 commits into
NuvioMedia:mainfrom
tdrkmn:fix/media-server-resume-row-title

Conversation

@tdrkmn

@tdrkmn tdrkmn commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The "Continue watching" row of a media server is now titled "Continue watching - " and gets no type suffix, on Home and in Reorder home catalogs. Before, it read "Continue watching - Movie" also when it held series. Library rows and addon rows keep their titles.

PR type

  • Translation/localization only
  • Critical bug fix
  • Approved feature/change

Affected area

  • Shared web app
  • Samsung Tizen
  • LG webOS
  • Browser development mode
  • Playback
  • Audio tracks
  • Subtitles
  • Focus / Remote navigation
  • UI / Layout
  • Resume / Watch progress
  • Continue Watching
  • Next Episode / Auto-play
  • Packaging / Build
  • Nuvio TV Installer compatibility
  • webOS Homebrew wrapper
  • Documentation
  • Other

Why

The resume catalog has to declare one type and declares movie, while it mixes movies and series. formatCatalogRowTitle() appends the type label to every row (when the suffix setting is on), and the reorder screen always appends it, so the row is labelled "Movie". Naming it after the server also tells two servers apart.

Issue or approval

Fixes #1593

Reproduction steps

  1. Connect an Emby server under Media Servers and start a series episode on it.
  2. Open Home, or Settings → Content & Discovery → Addons → Reorder home catalogs.
  3. The row reads "Continue watching - Movie".

Old behavior

"Continue watching - Movie" on Home and in the reorder screen.

New behavior

"Continue watching - Emby" (the connection name) on Home and in the reorder screen. "TV shows - Series", "Movies - Movie" and addon rows are unchanged.

Platform impact

Shared code with no platform API involved.

  • Samsung Tizen: same shared code path; the issue was found on a Samsung QE65Q90T (Tizen 5.5). This branch was not run on the TV
  • LG webOS: same shared code path; not tested, I do not have an LG TV
  • Browser development mode: tested, see below
  • Installer / packaging: none
  • Wrapper repositories: none

UI / behavior / playback impact

  • No UI change
  • No behavior change
  • No playback change
  • UI changed only to fix a documented glitch/bug
  • Behavior changed only to fix a documented bug/regression
  • Playback changed only to fix a documented bug/regression
  • UI change has explicit maintainer approval
  • Behavior change has explicit maintainer approval
  • Playback change has explicit maintainer approval

Installer, packaging, or wrapper impact

  • No installer, packaging, or wrapper impact
  • Tizen .wgt packaging changed
  • webOS .ipk packaging changed
  • App identifiers or metadata changed
  • local.properties / environment handling changed
  • sync:tizen changed
  • sync:webos changed
  • Nuvio TV Installer compatibility changed
  • webOS Homebrew metadata support changed

Policy check

  • I have read and understood CONTRIBUTING.md.
  • This PR fits the current PR policy or has explicit maintainer approval.
  • This PR is small, focused, and limited to one issue.
  • This PR does not bundle unrelated refactors, cleanups, formatting, or drive-by changes.
  • This PR does not add dependencies, architecture changes, platform rewrites, installer rewrites, or broad refactors without approval.
  • This PR does not change UI unless it fixes a linked glitch/bug or has explicit approval.
  • This PR does not change behavior unless it fixes a linked bug/regression or has explicit approval.
  • This PR does not change playback unless it fixes a linked bug/regression or has explicit approval.
  • This PR does not change installer, packaging, app identifiers, release flow, or wrapper behavior without clear need or approval.
  • I included a linked issue, reproduction steps, and testing notes if this is a critical bug fix.
  • I listed the testing performed below.

Feature additions, broad UI changes, refactors, playback rewrites, platform rewrites, installer rewrites, and other non-critical changes may be closed or deferred without review while Nuvio TV is being prepared for a stable Smart TV release.

Scope boundaries

Only the resume row's name and its type suffix changed. Not touched: its order key, disable key and hero key (built from addon id, type and catalog id, not from the name), the catalog type, the server name order (Android uses "Emby · Continue watching"; this keeps the TV's " - " form), and the library rows. package.json only registers the new test in npm test.

Testing

  • New test scripts/test-media-server-resume-row-title.mjs (3 cases): the resume catalog is named after the server, it gets no type suffix, library and addon rows keep it. All three fail on main.
  • Built app, clean profile, fake Emby with one series in progress: Home shows "Continue watching - Emby" instead of "Continue watching - Movie"; Reorder home catalogs lists "Continue watching - Emby" instead of "Continue watching - Movie"; "TV shows - Series" and "Movies - Movie" are unchanged in both.
  • Existing media-server and Continue Watching tests (including fix(home): list media-server rows in Reorder home catalogs #1591 and fix(continue-watching): store media-server episodes under their series #1592), lint and build pass.

Devices / platforms tested

Browser development mode (Chrome 158 on Windows 11, 1920x1080). Not run on a TV with this branch, and not tested on LG webOS.

Commands tested

node --test scripts/test-media-server-resume-row-title.mjs scripts/test-catalog-order-media-server-rows.mjs scripts/test-media-server-resume-series.mjs scripts/test-media-server-sync.mjs js/ui/screens/home/continueWatchingSeriesIdentity.test.mjs js/core/profile/mediaServerSyncScope.test.mjs
npm run lint
npm run build
npm test

In npm test, the tests in js/ui/screens/home/homeHeroBackdropBitmap.test.mjs fail or pass between runs on the same code, also on main without this change; that file does not touch media servers.

Manual test flow

Connect Emby → start an episode → Home; then Settings → Content & Discovery → Addons → Reorder home catalogs.

Screenshots / Video

Home, before (main):
title-before

Home, after:
title-after

Reorder home catalogs, before (main):
title-reorder-before

Reorder home catalogs, after:
title-reorder-after

Logs

Not applicable.

Regression risk

Low. The row keys do not contain the name, so order, disabled marks, custom titles and hero selection are kept. The only key built from the name is the legacy disable key that Home still accepts for a row, but no screen stores it for media-server rows: since #1591 the reorder screen stores the order key for them, and the phone management page does not list media-server rows. Nothing is pushed to the account for these rows.

Breaking changes

None.

Linked issues

Fixes #1593

tdrkmn and others added 2 commits November 21, 2026 19:06
The "Continue watching" row of a media server mixes movies and series, but
its catalog type is "movie", so Home and the reorder screen titled it
"Continue watching - Movie". The row is now named "Continue watching -
<server name>" and gets no type suffix. Library rows and addon rows keep
their titles.
Use "<server> · Continue watching" as Android does, still without the
type suffix because the row mixes movies and series. Stub the helper in
the tests that run the renderer in a VM, and cover the rendered title.
@WhiteGiso

Copy link
Copy Markdown
Member

Adjusted the row name to Android's format: <server> · Continue watching (e.g. Emby · Continue watching). It still gets no type suffix, since the row mixes movies and series. Also stubbed the new helper in the two tests that evaluate the renderers in a VM and added a check on the rendered legacy title.

Re-ran npm test, lint and build on the updated branch: all pass. The only other failures in node --test js/ui/screens/home/*.test.mjs are the three pre-existing homeLayoutPreferenceReads.test.mjs cases that already fail on main with ReferenceError: Platform is not defined; that file is not part of npm test.

@WhiteGiso
WhiteGiso merged commit ffa0a2c into NuvioMedia:main Nov 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Media-server "Continue watching" row is titled "Continue watching - Movie" also for series

2 participants