Repository navigation
feat(mad-libs): open the preview as soon as the app is built - #15
Conversation
| is missing or fails, give them that URL to open. Nothing watches the page, | ||
| so ask them to try it and tell you how it went. Report `build-app` only | ||
| after they say it works; if it doesn't, fix it and ask again. | ||
| it is whole. As soon as it is, call `show_preview` with |
There was a problem hiding this comment.
Why didn't this break and e2e test somewhere?
There was a problem hiding this comment.
Because this repo has no end-to-end test of a skill. npm test covers the package's hooks, preview server, and the Pi extension's form logic, all deterministic and with no model calls (the rule in docs/style/testing.md). A SKILL.md is prose the model follows, so nothing here can observe a change in when show_preview gets called.
The only thing that plays a skill end to end is boothstrap dev --verify --live, which runs the real station with the manifest's model, spends model credit, and needs macOS. CI here runs on Linux, so it doesn't run it. boothstrap's authoring guide positions --live as a nightly smoke run; that would need a macOS runner with a Gemini key secret. Until then the Mac playthrough in #8 is the e2e for skill changes.
Generated by Claude Code
Closes #14
The Mad Libs skill now calls
show_previewas soon asindex.htmlis built, without asking first, and says why it overrides the station's ask-first rule, as BirdsBirdBirds does. The improve-app step callsshow_previewagain after the change, which brings back a closed preview.Decide
Nothing.
Ready gate
npm run verify: ok for all 3 packages;npm test: 179 pass, 0 fail;npm run lint: 0 issues in 15 files. CI green on 15b5bd9: run 38849813116.Generated by Claude Code
<source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg">https://backend.blacksmith.sh/track/enable-autofix?expires=1794716154&installation_model_id=427356&pr_number=15&ref=codesmith_pr_footer&repository=MLH%2Fmicrohackathon-challenges&return_to=https%3A%2F%2Fgithub.com%2FMLH%2Fmicrohackathon-challenges%2Fpull%2F15&signature=130282a2af6790a80435905f3f50f07dd0390c28f325e1eedf4006dfaeffa0fe"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg">Need help on this PR? Tag
@codesmithwith what you need.