Skip to content

feat(mad-libs): open the preview as soon as the app is built - #15

Merged
theycallmeswift merged 2 commits into
mainfrom
feat/14-mad-libs-auto-preview
Oct 16, 2026
Merged

theycallmeswift merged 2 commits into
mainfrom
feat/14-mad-libs-auto-preview

Conversation

@theycallmeswift

@theycallmeswift theycallmeswift commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Closes #14

The Mad Libs skill now calls show_preview as soon as index.html is built, without asking first, and says why it overrides the station's ask-first rule, as BirdsBirdBirds does. The improve-app step calls show_preview again after the change, which brings back a closed preview.

Decide

Nothing.

Ready gate

Step Evidence
Tests and lint npm run verify: ok for all 3 packages; npm test: 179 pass, 0 fail; npm run lint: 0 issues in 15 files. CI green on 15b5bd9: run 38849813116. ✅
Red run n/a: a wording change to a skill file, no behavior under test ✅
Sibling sweep Searched the package README and test for the ask-first wording: no hits; BirdsBirdBirds already auto-opens ✅
Docs and specs None: the README does not describe the ask ✅
Standalone run No hook, server, or extension changed; the standalone flow is unchanged and URL fallback is kept ✅
Editorial pass Reread against docs/style/; dropped an unsourced claim about the station dialog. Orchestrator review: one nit (improve-app conditioned on a preview state the agent can't know), fixed. ✅
Skipped tests None ✅
Secrets, permissions Not touched ✅

Generated by Claude Code


&lt;source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"&gt;&lt;source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"&gt;&lt;img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"&gt; <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1794716154&installation_model_id=427356&pr_number=15&ref=codesmith_pr_footer&repository=MLH%2Fmicrohackathon-challenges&return_to=https%3A%2F%2Fgithub.com%2FMLH%2Fmicrohackathon-challenges%2Fpull%2F15&signature=130282a2af6790a80435905f3f50f07dd0390c28f325e1eedf4006dfaeffa0fe"&gt;&lt;picture&gt;&lt;source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"&gt;&lt;source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"&gt;&lt;img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"&gt;
Need help on this PR? Tag @codesmith with what you need.

@theycallmeswift
theycallmeswift marked this pull request as ready for review October 16, 2026 04:18
@theycallmeswift theycallmeswift self-assigned this Oct 16, 2026
is missing or fails, give them that URL to open. Nothing watches the page,
so ask them to try it and tell you how it went. Report `build-app` only
after they say it works; if it doesn't, fix it and ask again.
it is whole. As soon as it is, call `show_preview` with

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't this break and e2e test somewhere?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this repo has no end-to-end test of a skill. npm test covers the package's hooks, preview server, and the Pi extension's form logic, all deterministic and with no model calls (the rule in docs/style/testing.md). A SKILL.md is prose the model follows, so nothing here can observe a change in when show_preview gets called.

The only thing that plays a skill end to end is boothstrap dev --verify --live, which runs the real station with the manifest's model, spends model credit, and needs macOS. CI here runs on Linux, so it doesn't run it. boothstrap's authoring guide positions --live as a nightly smoke run; that would need a macOS runner with a Gemini key secret. Until then the Mac playthrough in #8 is the e2e for skill changes.


Generated by Claude Code

@theycallmeswift
theycallmeswift merged commit 3022021 into main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mad Libs: open the preview automatically once the app is built

2 participants