Repository navigation
Build the source package from an allow-list - #188
Merged
Merged
Conversation
The sdist used an exclude list, so any file in the working folder that was not git-ignored was packaged. A local build of 0.1.6 picked up a copy of the MIMIC-IV demo, a physionet.org mirror, editor settings, and local deployment notes (24 MB instead of about 50 KB). Released 0.1.5 already contained several of these local notes and settings files. List the paths that belong in the sdist instead: the package, tests, LICENSE, README.md, pyproject.toml, and requirements.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The source package (sdist) was built with an exclude list, so any file in the working folder that was not git-ignored was packaged. Building 0.1.6 from a working folder that held local data produced a 24 MB sdist containing a copy of the MIMIC-IV demo, a physionet.org mirror, editor settings, and local deployment notes.
This switches
[tool.hatch.build.targets.sdist]toonly-include, so the sdist contains only:physionet/tests/(including the synthetic E4 fixture)LICENSE,README.md,pyproject.toml,requirements.txtThe wheel already listed
packages = ["physionet"]and is unchanged.Note on 0.1.5
The released 0.1.5 sdist on PyPI already includes
.claude/settings.local.json,deploy.sh,DEPLOYMENT.md,FEATURE_REQUEST_VALIDATE.md, andPYPI_QUICKSTART.md. I checked them: they contain no credentials (token lines are placeholders such aspypi-YOUR_PRODUCTION_TOKEN_HERE) and no data. No MIMIC data was released.Verification
.gitignoreandPKG-INFOthat hatchling adds.physionet/only).twine check(twine 7.0) passes for both files.pytest -q: 257 passed, 1 skipped