Repository navigation
refactor: dedupe the StructuredGrid results container and rename it PropertyGrid - #363
Merged
Merged
Conversation
This was referenced Oct 29, 2026
lachlangrose
force-pushed
the
refactor/dedupe-structured-grid
branch
from
November 1, 2026 05:51
f609000 to
b2be874
Compare
lachlangrose
force-pushed
the
refactor/dedupe-structured-grid
branch
from
November 1, 2026 06:08
b2be874 to
a98a378
Compare
…ropertyGrid LoopStructural.geometry carried a copy of loop_common.geometry.StructuredGrid. Keep one class in loop_common (with the fuller docstrings), re-export it from LoopStructural.geometry, and rename it PropertyGrid because it is a result container, not the interpolation support loop_common.supports.StructuredGrid. StructuredGrid stays as an alias, so existing imports and pickles keep working. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
lachlangrose
force-pushed
the
refactor/dedupe-structured-grid
branch
from
November 1, 2026 06:54
a98a378 to
86bb5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not in this PR: changing the return type of `BoundingBox.structured_grid()` (it still returns the support class). That is planned as a follow-up.
Testing
🤖 Generated with Claude Code