[damrobi]

Content

This PR includes the removal of unused values from the STM crate and the activation of the snark feature by default across the full library.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)
  • Add ADR blog post or Dev ADR entry (if relevant)
  • No new TODOs introduced

Comments

Issue(s)

Relates to #3573

[github-actions]

Test Results

     5 files  ±  0     211 suites   - 25   2h 16m 47s ⏱️ + 8m 54s
 4 104 tests +  5   4 104 ✅ +  5  0 💤 ±0  0 ❌ ±0 
13 134 runs  +282  13 134 ✅ +282  0 💤 ±0  0 ❌ ±0 

Results for commit 4c65935. ± Comparison against base commit caa8432.

This pull request removes 11 and adds 16 tests. Note that renamed tests count towards both.

mithril-aggregator ‑ tools::genesis::operations::tests::bootstrap_test_genesis_certificate_works
mithril-aggregator ‑ tools::genesis::operations::tests::export_sign_then_import_genesis_payload
mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_certificate_chain_fails_when_adversarial_with_registered_signer_forgery_through_protocol_parameters
mithril-common ‑ entities::protocol_message::tests::rigid_preimage_total_byte_length_is_pinned_to_one_hundred_ninety
mithril-common ‑ test::builder::mithril_fixture::tests::bound_to_keeps_the_signer_unchanged
mithril-end-to-end ‑ mithril::genesis_keys::tests::legacy_keys_for_lagrange_without_the_snark_feature
mithril-stm ‑ proof_system::halo2_ivc_snark::prover_setup::tests::slow::ivc_setup_downsizes_keys_and_srs_to_the_circuit_degree
mithril-stm ‑ proof_system::halo2_ivc_snark::prover_setup::tests::slow::ivc_verifying_key_loaded_alone_is_the_one_of_the_setup
mithril-stm ‑ proof_system::halo2_ivc_snark::prover_setup::tests::slow::load_succeeds_with_unsafe_srs
mithril-stm ‑ proof_system::halo2_snark::aggregate_key::tests::properties::the_rigid_slot_carries_the_root_the_pad_and_the_little_endian_stake
…

mithril-client ‑ certificate_client::verify::tests::cache::early_stop_verification::commits_to_and_stops_in_the_space_of_a_dual_genesis_verification_key
mithril-client ‑ certificate_client::verify::tests::verification_key_formats::constructor_accepts_dual_verification_key_bundle
mithril-client ‑ certificate_client::verify::tests::verification_key_formats::verify_chain_succeeds_with_dual_bundle_on_pythagoras_chain
mithril-client ‑ certificate_client::verify::tests::verification_key_formats::verify_chain_succeeds_with_legacy_verification_key_on_lagrange_chain
mithril-client ‑ circuit_key_registry::tests::fails_on_a_response_exceeding_the_body_size_limit_before_using_it
mithril-client ‑ circuit_key_registry::tests::fails_when_no_network_is_served_by_the_aggregator_endpoint
mithril-client ‑ circuit_key_registry::tests::parses_a_network_without_registry_reference
mithril-client ‑ circuit_key_registry::tests::resolves_the_registry_of_the_network_matching_the_aggregator_endpoint
mithril-client ‑ circuit_key_registry::tests::retries_a_failed_download
mithril-client ‑ circuit_key_registry::tests::tolerates_top_level_metadata_entries_in_the_networks_configuration
…

♻️ This comment has been updated with latest results.